From: Pascal van Leeuwen <pascalvanl@gmail.com>
To: linux-crypto@vger.kernel.org
Cc: antoine.tenart@bootlin.com, herbert@gondor.apana.org.au,
davem@davemloft.net,
Pascal van Leeuwen <pvanleeuwen@verimatrix.com>
Subject: [PATCH 2/2] crypto: inside-secure: This fixes a mistake in a comment for XTS
Date: Tue, 30 Jul 2019 15:27:12 +0200 [thread overview]
Message-ID: <1564493232-30733-3-git-send-email-pvanleeuwen@verimatrix.com> (raw)
In-Reply-To: <1564493232-30733-1-git-send-email-pvanleeuwen@verimatrix.com>
This fixes a copy-paste (and forgot to edit) mistake in a comment
for XTS regarding the key length specification.
Signed-off-by: Pascal van Leeuwen <pvanleeuwen@verimatrix.com>
---
drivers/crypto/inside-secure/safexcel_cipher.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/inside-secure/safexcel_cipher.c b/drivers/crypto/inside-secure/safexcel_cipher.c
index a30fdd5..56dc8f9 100644
--- a/drivers/crypto/inside-secure/safexcel_cipher.c
+++ b/drivers/crypto/inside-secure/safexcel_cipher.c
@@ -1847,7 +1847,7 @@ struct safexcel_alg_template safexcel_alg_xts_aes = {
.setkey = safexcel_skcipher_aesxts_setkey,
.encrypt = safexcel_encrypt,
.decrypt = safexcel_decrypt,
- /* Add 4 to include the 4 byte nonce! */
+ /* XTS actually uses 2 AES keys glued together */
.min_keysize = AES_MIN_KEY_SIZE * 2,
.max_keysize = AES_MAX_KEY_SIZE * 2,
.ivsize = 16,
--
1.8.3.1
next prev parent reply other threads:[~2019-07-30 14:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 13:27 [PATCH 0/2] crypto: inside-secure - Cosmetic fixes for readability Pascal van Leeuwen
2019-07-30 13:27 ` [PATCH 1/2] crypto: inside-secure - Use defines instead of some constants (cosmetic) Pascal van Leeuwen
2019-07-30 14:35 ` Antoine Tenart
2019-08-09 6:17 ` Herbert Xu
2019-07-30 13:27 ` Pascal van Leeuwen [this message]
2019-07-30 14:37 ` [PATCH 2/2] crypto: inside-secure: This fixes a mistake in a comment for XTS Antoine Tenart
2019-08-09 5:10 ` Herbert Xu
2019-08-09 9:21 ` Pascal Van Leeuwen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1564493232-30733-3-git-send-email-pvanleeuwen@verimatrix.com \
--to=pascalvanl@gmail.com \
--cc=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=pvanleeuwen@verimatrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).