From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FA96C3B188 for ; Tue, 11 Feb 2020 07:55:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 182D2206CC for ; Tue, 11 Feb 2020 07:55:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qy7q2sC3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727866AbgBKHza (ORCPT ); Tue, 11 Feb 2020 02:55:30 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:46769 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726973AbgBKHz3 (ORCPT ); Tue, 11 Feb 2020 02:55:29 -0500 Received: by mail-pf1-f196.google.com with SMTP id k29so5065731pfp.13 for ; Mon, 10 Feb 2020 23:55:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=yMNaeQA1ruqb07d/gQkY9hQQ01qf8ZdkJJEE7bVrST0=; b=qy7q2sC3/9NT/KbvDHO5b+43/7xYnzO6GsBLhRg809ExUGmrFzUukRkO7Pv84N01jM 5vL0X0hzh2KtKwFyQxU0RHzh/WCdWw+zd4TKRZR3k0z1LlAl24QLRksf1ouxCVJKfNHY IRA/zvxnFJGY7+BR2A5iM2i0KUZ7ShOINrYZqWklxf1KbAJwe+eOvLJn1FsIE9DEPGCn 2uhhxUM32KNNQUbzTy8WV4bIUZpspI7zXjmwK4hTph0Yn7SXpvja6/8lUlYnEYrX11La xi7mJwc7Q1zgX2vOWUSV2LKQOFmkd5Secz5bvf1ngjC13IMvwjNaO6z+dO12k+P4gn8m VAtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=yMNaeQA1ruqb07d/gQkY9hQQ01qf8ZdkJJEE7bVrST0=; b=gIStWDSxC9CQ6NhJxquNqjCkdwOFf3GTPTnkrdSMUIWqBYXAAqJciQENsnIDF3XzxB vNF9Ww4lb/kOQMclefOZooG5xg/1U0wYDD7xr1btzf+c+v5FAtWMUjQ8C3g3FKk9jJOj 66CRdIkiESpLJ4nPiDf5yYxAOOMhSvHb1/OMi46CMbYwB39Uc6TcKTPrdGm4f3/45tFL eHlNF8IINBEQL4yyAayljbClCjiNOPVUAd9vPqf+kRWM8yXtgnbq11SJcLJdMMsB3tci xm/eH5YaOE2LneLABsVlGEIWJuvDG4FbJT6SPR2LTs/PFPL9PRVMxm3KUFaNGznX0Lyj Nvrg== X-Gm-Message-State: APjAAAUu4d1xDfkM1Xsa9FGlT0udM1DLmHzQFBFWAjO3R84vTPaswkin rAJviFyOdvGlOrkVcfIa+Rh+EA== X-Google-Smtp-Source: APXvYqwB/y69jqFMmPjxzXFUjA7Ef5wpPMq1/CHv/UDjvlKO+NPD1qw9XyOMHXF8sC7l5xeyBDAzZg== X-Received: by 2002:a63:f103:: with SMTP id f3mr501380pgi.394.1581407726884; Mon, 10 Feb 2020 23:55:26 -0800 (PST) Received: from localhost.localdomain ([45.135.186.96]) by smtp.gmail.com with ESMTPSA id d73sm3011627pfd.109.2020.02.10.23.55.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 10 Feb 2020 23:55:26 -0800 (PST) From: Zhangfei Gao To: Greg Kroah-Hartman , Arnd Bergmann , Herbert Xu , jonathan.cameron@huawei.com, dave.jiang@intel.com, grant.likely@arm.com, jean-philippe , Jerome Glisse , ilias.apalodimas@linaro.org, francois.ozog@linaro.org, kenneth-lee-2012@foxmail.com, Wangzhou , "haojian . zhuang" , guodong.xu@linaro.org Cc: linux-accelerators@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, iommu@lists.linux-foundation.org, Zhangfei Gao Subject: [PATCH v13 3/4] crypto: hisilicon - Remove module_param uacce_mode Date: Tue, 11 Feb 2020 15:54:24 +0800 Message-Id: <1581407665-13504-4-git-send-email-zhangfei.gao@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1581407665-13504-1-git-send-email-zhangfei.gao@linaro.org> References: <1581407665-13504-1-git-send-email-zhangfei.gao@linaro.org> Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Remove the module_param uacce_mode, which is not used currently. Reviewed-by: Greg Kroah-Hartman Reviewed-by: Jonathan Cameron Signed-off-by: Zhangfei Gao Signed-off-by: Zhou Wang --- drivers/crypto/hisilicon/zip/zip_main.c | 31 +++++-------------------- 1 file changed, 6 insertions(+), 25 deletions(-) diff --git a/drivers/crypto/hisilicon/zip/zip_main.c b/drivers/crypto/hisilicon/zip/zip_main.c index e1bab1a91333..93345f0d7415 100644 --- a/drivers/crypto/hisilicon/zip/zip_main.c +++ b/drivers/crypto/hisilicon/zip/zip_main.c @@ -297,9 +297,6 @@ static u32 pf_q_num = HZIP_PF_DEF_Q_NUM; module_param_cb(pf_q_num, &pf_q_num_ops, &pf_q_num, 0444); MODULE_PARM_DESC(pf_q_num, "Number of queues in PF(v1 1-4096, v2 1-1024)"); -static int uacce_mode; -module_param(uacce_mode, int, 0); - static u32 vfs_num; module_param(vfs_num, uint, 0444); MODULE_PARM_DESC(vfs_num, "Number of VFs to enable(1-63)"); @@ -791,6 +788,7 @@ static int hisi_zip_probe(struct pci_dev *pdev, const struct pci_device_id *id) pci_set_drvdata(pdev, hisi_zip); qm = &hisi_zip->qm; + qm->use_dma_api = true; qm->pdev = pdev; qm->ver = rev_id; @@ -798,20 +796,6 @@ static int hisi_zip_probe(struct pci_dev *pdev, const struct pci_device_id *id) qm->dev_name = hisi_zip_name; qm->fun_type = (pdev->device == PCI_DEVICE_ID_ZIP_PF) ? QM_HW_PF : QM_HW_VF; - switch (uacce_mode) { - case 0: - qm->use_dma_api = true; - break; - case 1: - qm->use_dma_api = false; - break; - case 2: - qm->use_dma_api = true; - break; - default: - return -EINVAL; - } - ret = hisi_qm_init(qm); if (ret) { dev_err(&pdev->dev, "Failed to init qm!\n"); @@ -1010,12 +994,10 @@ static int __init hisi_zip_init(void) goto err_pci; } - if (uacce_mode == 0 || uacce_mode == 2) { - ret = hisi_zip_register_to_crypto(); - if (ret < 0) { - pr_err("Failed to register driver to crypto.\n"); - goto err_crypto; - } + ret = hisi_zip_register_to_crypto(); + if (ret < 0) { + pr_err("Failed to register driver to crypto.\n"); + goto err_crypto; } return 0; @@ -1030,8 +1012,7 @@ static int __init hisi_zip_init(void) static void __exit hisi_zip_exit(void) { - if (uacce_mode == 0 || uacce_mode == 2) - hisi_zip_unregister_from_crypto(); + hisi_zip_unregister_from_crypto(); pci_unregister_driver(&hisi_zip_pci_driver); hisi_zip_unregister_debugfs(); } -- 2.23.0