From: Haren Myneni <haren@linux.ibm.com>
To: herbert@gondor.apana.org.au
Cc: mpe@ellerman.id.au, mikey@neuling.org,
sukadev@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org,
linux-crypto@vger.kernel.org, npiggin@gmail.com
Subject: [PATCH V2 4/9] crypto/nx: Initialize coproc entry with kzalloc
Date: Sat, 29 Feb 2020 03:15:02 -0800 [thread overview]
Message-ID: <1582974902.18705.46.camel@hbabu-laptop> (raw)
In-Reply-To: <1582974266.18705.28.camel@hbabu-laptop>
coproc entry is initialized during NX probe on power9, but not on P8.
nx842_delete_coprocs() is used for both and frees receive window if it
is allocated. Getting crash for rmmod on P8 since coproc->vas.rxwin
is not initialized.
This patch replaces kmalloc with kzalloc in nx842_powernv_probe()
Signed-off-by: Haren Myneni <haren@linux.ibm.com>
---
drivers/crypto/nx/nx-842-powernv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/nx/nx-842-powernv.c b/drivers/crypto/nx/nx-842-powernv.c
index c037a24..8e63326 100644
--- a/drivers/crypto/nx/nx-842-powernv.c
+++ b/drivers/crypto/nx/nx-842-powernv.c
@@ -922,7 +922,7 @@ static int __init nx842_powernv_probe(struct device_node *dn)
return -EINVAL;
}
- coproc = kmalloc(sizeof(*coproc), GFP_KERNEL);
+ coproc = kzalloc(sizeof(*coproc), GFP_KERNEL);
if (!coproc)
return -ENOMEM;
--
1.8.3.1
next prev parent reply other threads:[~2020-02-29 11:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-29 11:04 [PATCH V2 0/9] crypto/nx: Enable GZIP engine and provide userpace API Haren Myneni
2020-02-29 11:11 ` [PATCH V2 1/9] powerpc/vas: Initialize window attributes for GZIP coprocessor type Haren Myneni
2020-02-29 11:11 ` [PATCH V2 2/9] powerpc/vas: Define VAS_TX_WIN_OPEN ioctl API Haren Myneni
2020-02-29 11:14 ` [PATCH V3 3/9] powerpc/vas: Add VAS user space API Haren Myneni
2020-02-29 11:15 ` Haren Myneni [this message]
2020-02-29 11:15 ` [PATCH V2 5/9] crypto/nx: Rename nx-842-powernv file name to nx-common-powernv Haren Myneni
2020-02-29 11:16 ` [PATCH V2 6/9] crypto/nx: Make enable code generic to add new GZIP compression type Haren Myneni
2020-02-29 11:17 ` [PATCH V2 7/9] crypto/nx: Enable and setup " Haren Myneni
2020-02-29 11:17 ` [PATCH V2 8/9] crypto/nx: Remove 'pid' in vas_tx_win_attr struct Haren Myneni
2020-02-29 11:18 ` [PATCH V2 9/9] Documentation/powerpc: VAS API Haren Myneni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1582974902.18705.46.camel@hbabu-laptop \
--to=haren@linux.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).