From: Zaibo Xu <xuzaibo@huawei.com> To: <herbert@gondor.apana.org.au>, <davem@davemloft.net> Cc: <linux-crypto@vger.kernel.org>, <linuxarm@huawei.com>, <jonathan.cameron@huawei.com>, <wangzhou1@hisilicon.com>, <tanghui20@huawei.com>, <yekai13@huawei.com>, <liulongfang@huawei.com>, <qianweili@huawei.com>, <zhangwei375@huawei.com>, <fanghao11@huawei.com>, <forest.zhouchang@huawei.com> Subject: [PATCH v3 2/5] crypto: hisilicon/sec2 - Add workqueue for SEC driver. Date: Thu, 5 Mar 2020 10:06:22 +0800 [thread overview] Message-ID: <1583373985-718-3-git-send-email-xuzaibo@huawei.com> (raw) In-Reply-To: <1583373985-718-1-git-send-email-xuzaibo@huawei.com> From: Ye Kai <yekai13@huawei.com> Allocate one workqueue for each QM instead of one for all QMs, we found the throughput of SEC engine can be increased to the hardware limit throughput during testing sec2 performance. so we added this scheme. Signed-off-by: Ye Kai <yekai13@huawei.com> Signed-off-by: Longfang Liu <liulongfang@huawei.com> Signed-off-by: Zaibo Xu <xuzaibo@huawei.com> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> --- drivers/crypto/hisilicon/sec2/sec_main.c | 32 +++++++++++++++++++++++++++++--- 1 file changed, 29 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/hisilicon/sec2/sec_main.c b/drivers/crypto/hisilicon/sec2/sec_main.c index 3767fdb..1fe2558 100644 --- a/drivers/crypto/hisilicon/sec2/sec_main.c +++ b/drivers/crypto/hisilicon/sec2/sec_main.c @@ -774,12 +774,30 @@ static void sec_qm_uninit(struct hisi_qm *qm) static int sec_probe_init(struct hisi_qm *qm, struct sec_dev *sec) { + int ret; + + /* + * WQ_HIGHPRI: SEC request must be low delayed, + * so need a high priority workqueue. + * WQ_UNBOUND: SEC task is likely with long + * running CPU intensive workloads. + */ + qm->wq = alloc_workqueue("%s", WQ_HIGHPRI | + WQ_MEM_RECLAIM | WQ_UNBOUND, num_online_cpus(), + pci_name(qm->pdev)); + if (!qm->wq) { + pci_err(qm->pdev, "fail to alloc workqueue\n"); + return -ENOMEM; + } + if (qm->fun_type == QM_HW_PF) { qm->qp_base = SEC_PF_DEF_Q_BASE; qm->qp_num = pf_q_num; qm->debug.curr_qm_qp_num = pf_q_num; - return sec_pf_probe_init(sec); + ret = sec_pf_probe_init(sec); + if (ret) + goto err_probe_uninit; } else if (qm->fun_type == QM_HW_VF) { /* * have no way to get qm configure in VM in v1 hardware, @@ -792,18 +810,26 @@ static int sec_probe_init(struct hisi_qm *qm, struct sec_dev *sec) qm->qp_num = SEC_QUEUE_NUM_V1 - SEC_PF_DEF_Q_NUM; } else if (qm->ver == QM_HW_V2) { /* v2 starts to support get vft by mailbox */ - return hisi_qm_get_vft(qm, &qm->qp_base, &qm->qp_num); + ret = hisi_qm_get_vft(qm, &qm->qp_base, &qm->qp_num); + if (ret) + goto err_probe_uninit; } } else { - return -ENODEV; + ret = -ENODEV; + goto err_probe_uninit; } return 0; +err_probe_uninit: + destroy_workqueue(qm->wq); + return ret; } static void sec_probe_uninit(struct hisi_qm *qm) { hisi_qm_dev_err_uninit(qm); + + destroy_workqueue(qm->wq); } static int sec_probe(struct pci_dev *pdev, const struct pci_device_id *id) -- 2.8.1
next prev parent reply other threads:[~2020-03-05 2:10 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-05 2:06 [PATCH v3 0/5] crypto: hisilicon - Improve SEC performance Zaibo Xu 2020-03-05 2:06 ` [PATCH v3 1/5] crypto: hisilicon - Use one workqueue per qm instead of per qp Zaibo Xu 2020-03-05 2:06 ` Zaibo Xu [this message] 2020-03-05 2:06 ` [PATCH v3 3/5] crypto: hisilicon/sec2 - Add iommu status check Zaibo Xu 2020-03-05 2:06 ` [PATCH v3 4/5] crypto: hisilicon/sec2 - Update IV and MAC operation Zaibo Xu 2020-03-05 2:06 ` [PATCH v3 5/5] crypto: hisilicon/sec2 - Add pbuffer mode for SEC driver Zaibo Xu 2020-03-12 12:39 ` [PATCH v3 0/5] crypto: hisilicon - Improve SEC performance Herbert Xu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1583373985-718-3-git-send-email-xuzaibo@huawei.com \ --to=xuzaibo@huawei.com \ --cc=davem@davemloft.net \ --cc=fanghao11@huawei.com \ --cc=forest.zhouchang@huawei.com \ --cc=herbert@gondor.apana.org.au \ --cc=jonathan.cameron@huawei.com \ --cc=linux-crypto@vger.kernel.org \ --cc=linuxarm@huawei.com \ --cc=liulongfang@huawei.com \ --cc=qianweili@huawei.com \ --cc=tanghui20@huawei.com \ --cc=wangzhou1@hisilicon.com \ --cc=yekai13@huawei.com \ --cc=zhangwei375@huawei.com \ --subject='Re: [PATCH v3 2/5] crypto: hisilicon/sec2 - Add workqueue for SEC driver.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).