From: Sebastian Siewior <linux-crypto@ml.breakpoint.cc>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org, davem@davemloft.net
Subject: Re: [patch] [CRYPTO] add alignment for setkey()
Date: Fri, 18 May 2007 16:37:39 +0200 [thread overview]
Message-ID: <20070518143739.GC16349@Chamillionaire.breakpoint.cc> (raw)
In-Reply-To: <20070518134632.GA21326@gondor.apana.org.au>
* Herbert Xu | 2007-05-18 23:46:32 [+1000]:
>> Good point. I take kmalloc() with GFP_KERNEL (the caller should not be
>> atomic at this point). Additionaly I zero the temporary key (I don't
>
>They shouldn't be. But it would be good if you could do a grep to see
>if any of them are doing it in an atomic context since we've not tested
>for this before.
Huh, this was too fast. I greped after sending the patch...
drivers/net/ppp_mppe.c: can't tell, probably not.
net/mac80211/wep.c: caller is requesting memory with GFP_ATOMIC. The
code might get called from a tasklet handler but can't really say. There
are some skbs around.
The others are pretty easy to tell and they don't, just the mac80211.
Do you s/GFP_KERNEL/GFP_ATOMIC/ ?
>Thanks,
Sebastian
prev parent reply other threads:[~2007-05-18 14:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-10 9:57 [patch] [CRYPTO] add alignment for setkey() Sebastian Siewior
2007-05-18 6:30 ` Herbert Xu
2007-05-18 13:43 ` Sebastian Siewior
2007-05-18 13:46 ` Herbert Xu
2007-05-18 14:37 ` Sebastian Siewior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070518143739.GC16349@Chamillionaire.breakpoint.cc \
--to=linux-crypto@ml.breakpoint.cc \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).