linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Joy Latten <latten@austin.ibm.com>
Cc: linux-crypto@vger.kernel.org
Subject: Re: [PATCH 8/8] [CRYPTO] aead: Add authenc
Date: Fri, 28 Sep 2007 09:10:23 +0800	[thread overview]
Message-ID: <20070928011023.GB22657@gondor.apana.org.au> (raw)
In-Reply-To: <200709272229.l8RMT4n3003226@faith.austin.ibm.com>

On Thu, Sep 27, 2007 at 05:29:04PM -0500, Joy Latten wrote:
>
> Thus if user enters template without whitespaces,
> then the above would cause a problem because the 
> name in the template would not match up with the name
> in the instance above. 

Indeed, white spaces are not allowed so they should go from
these prints.  I've fixed it in my tree as below.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
diff --git a/crypto/authenc.c b/crypto/authenc.c
index 86b3ac8..0b29a6a 100644
--- a/crypto/authenc.c
+++ b/crypto/authenc.c
@@ -312,12 +312,12 @@ static struct crypto_instance *crypto_authenc_alloc(struct rtattr **tb)
 
 	err = -ENAMETOOLONG;
 	if (snprintf(inst->alg.cra_name, CRYPTO_MAX_ALG_NAME,
-		     "authenc(%s, %u, %s, %u)", auth->cra_name, authsize,
+		     "authenc(%s,%u,%s,%u)", auth->cra_name, authsize,
 		     enc->cra_name, enckeylen) >= CRYPTO_MAX_ALG_NAME)
 		goto err_free_inst;
 
 	if (snprintf(inst->alg.cra_driver_name, CRYPTO_MAX_ALG_NAME,
-		     "authenc(%s, %u, %s, %u)", auth->cra_driver_name,
+		     "authenc(%s,%u,%s,%u)", auth->cra_driver_name,
 		     authsize, enc->cra_driver_name, enckeylen) >=
 	    CRYPTO_MAX_ALG_NAME)
 		goto err_free_inst;

  reply	other threads:[~2007-09-28  1:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-27 22:29 [PATCH 8/8] [CRYPTO] aead: Add authenc Joy Latten
2007-09-28  1:10 ` Herbert Xu [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-08-30  8:39 [0/8] [CRYPTO]: Add AEAD/authenc support Herbert Xu
2007-08-30  8:41 ` [PATCH 8/8] [CRYPTO] aead: Add authenc Herbert Xu
2007-08-30 11:00   ` Ronen Shitrit
2007-08-30 11:13     ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070928011023.GB22657@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=latten@austin.ibm.com \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).