From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [bug report] crypto: chcr - Add AEAD algos. Date: Thu, 1 Dec 2016 23:48:58 +0300 Message-ID: <20161201204858.GA10660@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-crypto@vger.kernel.org To: harsh@chelsio.com Return-path: Received: from userp1040.oracle.com ([156.151.31.81]:49734 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752365AbcLAUtV (ORCPT ); Thu, 1 Dec 2016 15:49:21 -0500 Content-Disposition: inline Sender: linux-crypto-owner@vger.kernel.org List-ID: Hello Harsh Jain, This is a semi-automatic email about new static checker warnings. The patch 2debd3325e55: "crypto: chcr - Add AEAD algos." from Nov 29, 2016, leads to the following Smatch complaint: drivers/crypto/chelsio/chcr_algo.c:2460 chcr_aead_op() warn: variable dereferenced before check 'ctx' (see line 2457) drivers/crypto/chelsio/chcr_algo.c:2460 chcr_aead_op() warn: variable dereferenced before check 'ctx->dev' (see line 2457) drivers/crypto/chelsio/chcr_algo.c 2456 struct chcr_context *ctx = crypto_aead_ctx(tfm); 2457 struct uld_ctx *u_ctx = ULD_CTX(ctx); ^^^^^^^^^^^^ Derefences both. 2458 struct sk_buff *skb; 2459 2460 if (ctx && !ctx->dev) { ^^^^^^^^^^^^^^^^ Check is too late. 2461 pr_err("chcr : %s : No crypto device.\n", __func__); 2462 return -ENXIO; regards, dan carpenter