From mboxrd@z Thu Jan 1 00:00:00 1970 From: Herbert Xu Subject: Re: [PATCH v2 1/3] crypto: chacha20 - convert generic and x86 versions to skcipher Date: Wed, 28 Dec 2016 17:18:01 +0800 Message-ID: <20161228091801.GA12318@gondor.apana.org.au> References: <1481294033-23508-1-git-send-email-ard.biesheuvel@linaro.org> <1481294033-23508-2-git-send-email-ard.biesheuvel@linaro.org> <20161227100452.GB10629@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org To: Ard Biesheuvel Return-path: Received: from helcar.hengli.com.au ([209.40.204.226]:38071 "EHLO helcar.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751103AbcL1JSK (ORCPT ); Wed, 28 Dec 2016 04:18:10 -0500 Content-Disposition: inline In-Reply-To: <20161227100452.GB10629@gondor.apana.org.au> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Tue, Dec 27, 2016 at 06:04:52PM +0800, Herbert Xu wrote: > On Fri, Dec 09, 2016 at 02:33:51PM +0000, Ard Biesheuvel wrote: > > This converts the ChaCha20 code from a blkcipher to a skcipher, which > > is now the preferred way to implement symmetric block and stream ciphers. > > > > This ports the generic and x86 versions at the same time because the > > latter reuses routines of the former. > > > > Note that the skcipher_walk() API guarantees that all presented blocks > > except the final one are a multiple of the chunk size, so we can simplify > > the encrypt() routine somewhat. > > > > Signed-off-by: Ard Biesheuvel > > Patch applied. Thanks. I'm reverting this patch because it breaks the build on ARM without the two subsequent patches. When resubmitting please make sure that the kernel can build and work after each patch. Otherwise git bisections will fail. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt