archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <>
To: Herbert Xu <>
Cc: Arnd Bergmann <>,
	"David S. Miller" <>,
	Matthias Brugger <>,
	Ryder Lee <>,,,,
Subject: [PATCH 1/2] crypto: mediatek - remove ARM dependencies
Date: Wed, 11 Jan 2017 14:50:19 +0100	[thread overview]
Message-ID: <> (raw)

Building the mediatek driver on an older ARM architecture results in a
harmless warning:

warning: (ARCH_OMAP2PLUS_TYPICAL && CRYPTO_DEV_MEDIATEK) selects NEON which has unmet direct dependencies (VFPv3 && CPU_V7)

We could add an explicit dependency on CPU_V7, but it seems nicer to
open up the build to additional configurations. This replaces the ARM
optimized algorithm selection with the normal one that all other drivers
use, and that in turn lets us relax the dependency on ARM and drop
a number of the unrelated 'select' statements.

Obviously a real user would still select those other optimized drivers
as a fallback, but as there is no strict dependency, we can leave that
up to the user.

Fixes: 785e5c616c84 ("crypto: mediatek - Add crypto driver support for some MediaTek chips")
Signed-off-by: Arnd Bergmann <>
 drivers/crypto/Kconfig | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index 8ded3af88b16..9d37ae07b4ce 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -555,15 +555,12 @@ config CRYPTO_DEV_ROCKCHIP
 	tristate "MediaTek's EIP97 Cryptographic Engine driver"
-	select NEON
-	select ARM_CRYPTO
 	select CRYPTO_AES
-	select CRYPTO_SHA256_ARM
-	select CRYPTO_SHA512_ARM
+	select CRYPTO_SHA1
+	select CRYPTO_SHA256
+	select CRYPTO_SHA512
 	select CRYPTO_HMAC
 	  This driver allows you to utilize the hardware crypto accelerator

             reply	other threads:[~2017-01-11 13:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-11 13:50 Arnd Bergmann [this message]
2017-01-11 13:55 ` [PATCH 2/2] crypto: mediatek - fix format string for 64-bit builds Arnd Bergmann
2017-01-12 16:44   ` Herbert Xu
2017-01-12 16:44 ` [PATCH 1/2] crypto: mediatek - remove ARM dependencies Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).