From: Herbert Xu <herbert@gondor.apana.org.au>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andy Lutomirski <luto@kernel.org>
Subject: Re: x86-64: Maintain 16-byte stack alignment
Date: Thu, 12 Jan 2017 14:12:11 +0800 [thread overview]
Message-ID: <20170112061211.GA10247@gondor.apana.org.au> (raw)
In-Reply-To: <CAKv+Gu8xVrfR=J5b2pGK7R5Tv-M3xZhL_dnTvvM7nTZLLtC-EQ@mail.gmail.com>
On Tue, Jan 10, 2017 at 05:30:48PM +0000, Ard Biesheuvel wrote:
>
> Apologies for introducing this breakage. It seemed like an obvious and
> simple cleanup, so I didn't even bother to mention it in the commit
> log, but if the kernel does not guarantee 16 byte alignment, I guess
> we should revert to the old method. If SSE instructions are the only
> ones that require this alignment, then I suppose not having a ABI
> conforming stack pointer should not be an issue in general.
BTW Ard, what is the stack alignment on ARM64?
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2017-01-12 6:12 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 14:33 x86-64: Maintain 16-byte stack alignment Herbert Xu
2017-01-10 14:39 ` Herbert Xu
2017-01-10 17:05 ` Linus Torvalds
2017-01-10 17:09 ` Andy Lutomirski
2017-01-11 3:11 ` Herbert Xu
2017-01-11 3:30 ` Linus Torvalds
2017-01-11 4:17 ` Linus Torvalds
2017-01-11 4:35 ` Herbert Xu
2017-01-11 6:01 ` Andy Lutomirski
2017-01-12 6:21 ` Andy Lutomirski
2017-01-12 7:40 ` Ingo Molnar
2017-01-12 14:02 ` Josh Poimboeuf
2017-01-12 19:51 ` Linus Torvalds
2017-01-12 20:08 ` Andy Lutomirski
2017-01-12 20:15 ` Josh Poimboeuf
2017-01-12 20:55 ` Josh Poimboeuf
2017-01-12 21:40 ` Linus Torvalds
2017-01-13 8:38 ` Herbert Xu
2017-01-13 1:46 ` Andy Lutomirski
2017-01-13 3:11 ` Josh Poimboeuf
2017-01-13 3:23 ` Andy Lutomirski
2017-01-13 4:27 ` Josh Poimboeuf
[not found] ` <CA+55aFzRrSwGxxfZk-RUEnsz=xhcSmOwE1CenfCPBWtsS9MwDw@mail.gmail.com>
2017-01-13 5:07 ` Josh Poimboeuf
2017-01-13 8:43 ` Herbert Xu
2017-01-13 8:42 ` Herbert Xu
2017-01-13 8:39 ` Herbert Xu
2017-01-13 8:36 ` Herbert Xu
2017-01-13 13:07 ` Josh Poimboeuf
[not found] ` <CA+55aFw+Z_ieo6DzTVB6_-TvQ0jj60s=T0mvXfqkBVFdKFPw_Q@mail.gmail.com>
2017-01-11 8:06 ` Ard Biesheuvel
2017-01-11 8:09 ` Herbert Xu
2017-01-11 18:20 ` Andy Lutomirski
2017-01-12 7:05 ` Herbert Xu
2017-01-12 7:46 ` Ingo Molnar
2017-01-12 14:49 ` Josh Poimboeuf
2017-01-12 7:51 ` Andy Lutomirski
2017-01-12 8:04 ` Herbert Xu
2017-01-12 8:18 ` Ingo Molnar
2017-01-12 15:03 ` Josh Poimboeuf
2017-01-12 15:06 ` Herbert Xu
2017-01-12 15:18 ` Josh Poimboeuf
2017-01-12 15:10 ` Josh Poimboeuf
2017-01-10 17:30 ` Ard Biesheuvel
2017-01-10 19:00 ` Andy Lutomirski
2017-01-10 19:16 ` Ard Biesheuvel
2017-01-10 19:22 ` Andy Lutomirski
2017-01-10 20:00 ` Ard Biesheuvel
2017-01-10 23:25 ` Andy Lutomirski
2017-01-11 3:26 ` Herbert Xu
2017-01-11 3:26 ` Herbert Xu
2017-01-11 3:16 ` Herbert Xu
2017-01-11 3:15 ` Herbert Xu
2017-01-12 6:12 ` Herbert Xu [this message]
2017-01-12 8:01 ` Ard Biesheuvel
2017-01-12 8:06 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170112061211.GA10247@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ard.biesheuvel@linaro.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).