linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: harsh@chelsio.com
Cc: linux-crypto@vger.kernel.org
Subject: Re: [bug report] crypto: chcr - Add AEAD algos.
Date: Tue, 24 Jan 2017 13:43:13 +0300	[thread overview]
Message-ID: <20170124104313.GD4201@mwanda> (raw)
In-Reply-To: <20161201204858.GA10660@mwanda>

Ping?

regards,
dan carpenter

On Thu, Dec 01, 2016 at 11:48:58PM +0300, Dan Carpenter wrote:
> Hello Harsh Jain,
> 
> This is a semi-automatic email about new static checker warnings.
> 
> The patch 2debd3325e55: "crypto: chcr - Add AEAD algos." from Nov 29, 
> 2016, leads to the following Smatch complaint:
> 
> 	drivers/crypto/chelsio/chcr_algo.c:2460 chcr_aead_op()
> 	warn: variable dereferenced before check 'ctx' (see line 2457)
> 
> 	drivers/crypto/chelsio/chcr_algo.c:2460 chcr_aead_op()
> 	warn: variable dereferenced before check 'ctx->dev' (see line 2457)
> 
> drivers/crypto/chelsio/chcr_algo.c
>   2456		struct chcr_context *ctx = crypto_aead_ctx(tfm);
>   2457		struct uld_ctx *u_ctx = ULD_CTX(ctx);
>                                         ^^^^^^^^^^^^
> Derefences both.
> 
>   2458		struct sk_buff *skb;
>   2459	
>   2460		if (ctx && !ctx->dev) {
>                     ^^^^^^^^^^^^^^^^
> Check is too late.
> 
>   2461			pr_err("chcr : %s : No crypto device.\n", __func__);
>   2462			return -ENXIO;
> 
> regards,
> dan carpenter

      reply	other threads:[~2017-01-24 10:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-01 20:48 Dan Carpenter
2017-01-24 10:43 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170124104313.GD4201@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=harsh@chelsio.com \
    --cc=linux-crypto@vger.kernel.org \
    --subject='Re: [bug report] crypto: chcr - Add AEAD algos.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).