From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alden Tondettar <alden.tondettar@gmail.com>
Cc: Theodore Ts'o <tytso@mit.edu>, Arnd Bergmann <arnd@arndb.de>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] random: Don't overwrite CRNG state in crng_initialize()
Date: Thu, 9 Feb 2017 10:23:35 +0100 [thread overview]
Message-ID: <20170209092335.GB10164@kroah.com> (raw)
In-Reply-To: <20170209090432.GA18039@rincewind>
On Thu, Feb 09, 2017 at 02:04:32AM -0700, Alden Tondettar wrote:
> On Thu, Feb 09, 2017 at 07:47:25AM +0100, Greg Kroah-Hartman wrote:
> > On Wed, Feb 08, 2017 at 08:31:26PM -0700, Alden Tondettar wrote:
> > > In short, the situation is:
> > >
> > > A) No usable hardware RNG or arch_get_random() (or we don't trust it...)
> >
> > Wait, why would you not trust arch_get_random()? Is it broken somehow
> > on some arches? If so, why not fix that as well?
>
> arch_get_random() makes use of RDRAND and similar CPU features. Some people
> do not wish to trust black-box RNG implementations.
It does not use those features "raw", it uses the output to feed the
entropy, which, from my understanding, should be the same as feeding any
other form of data into the system, right?
So while it is always nice to worry about different things, I think this
is something that is very low on the "possible to cause an issue" scale.
thanks,
greg k-h
next prev parent reply other threads:[~2017-02-09 9:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 3:31 [PATCH] random: Don't overwrite CRNG state in crng_initialize() Alden Tondettar
2017-02-09 4:19 ` Theodore Ts'o
2017-02-09 8:13 ` Alden Tondettar
2017-02-09 17:56 ` Theodore Ts'o
2017-02-09 18:32 ` Theodore Ts'o
2017-02-09 6:47 ` Greg Kroah-Hartman
2017-02-09 9:04 ` Alden Tondettar
2017-02-09 9:23 ` Greg Kroah-Hartman [this message]
2017-02-09 9:26 ` Stephan Müller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170209092335.GB10164@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alden.tondettar@gmail.com \
--cc=arnd@arndb.de \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).