From mboxrd@z Thu Jan 1 00:00:00 1970 From: Herbert Xu Subject: Re: [PATCH] crypto: arm64/crc32 - merge CRC32 and PMULL instruction based drivers Date: Sat, 11 Feb 2017 18:51:02 +0800 Message-ID: <20170211105102.GB855@gondor.apana.org.au> References: <1485963340-25297-1-git-send-email-ard.biesheuvel@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, will.deacon@arm.com, yazen.ghannam@linaro.org, steve.capper@linaro.org, agraf@suse.de, mbrugger@suse.com To: Ard Biesheuvel Return-path: Received: from helcar.hengli.com.au ([209.40.204.226]:36097 "EHLO helcar.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750966AbdBKTAM (ORCPT ); Sat, 11 Feb 2017 14:00:12 -0500 Content-Disposition: inline In-Reply-To: <1485963340-25297-1-git-send-email-ard.biesheuvel@linaro.org> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Wed, Feb 01, 2017 at 03:35:40PM +0000, Ard Biesheuvel wrote: > The PMULL based CRC32 implementation already contains code based on the > separate, optional CRC32 instructions to fallback to when operating on > small quantities of data. We can expose these routines directly on systems > that lack the 64x64 PMULL instructions but do implement the CRC32 ones, > which makes the driver that is based solely on those CRC32 instructions > redundant. So remove it. > > Note that this aligns arm64 with ARM, whose accelerated CRC32 driver > also combines the CRC32 extension based and the PMULL based versions. > > Signed-off-by: Ard Biesheuvel Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt