From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Stephan Müller" <smueller@chronox.de>
Cc: linux-crypto@vger.kernel.org
Subject: Re: [RFC] how to handle AAD copy operation for algif_aead
Date: Thu, 9 Mar 2017 18:00:11 +0800 [thread overview]
Message-ID: <20170309100011.GA6844@gondor.apana.org.au> (raw)
In-Reply-To: <13406914.zeok8basum@positron.chronox.de>
On Fri, Feb 24, 2017 at 02:24:47PM +0100, Stephan Müller wrote:
> Hi Herbert et al,
>
> attached are two patches where each patch has a different approach to copy the
> AAD in the algif_aead operation. I would like to hear your opinion which
> approach should be taken.
>
> The patch 0001-crypto-algif_aead-copy-AAD-from-src-to-dst_separate.patch
> simply copies the AAD over from TX SGL to RX SGL. The pro is that the patch is
> small. The con is that this approach does *not* provide an in-place crypto
> operation.
I prefer this patch with the proviso that it copy the whole thing
instead of just the AD. That way you can just feed the dst memory
to crypto_aead for in-place operation. Of course you have to mangle
the tag data onto the dst SG list for decryption but it shouldn't
be too hard.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2017-03-09 10:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 13:24 [RFC] how to handle AAD copy operation for algif_aead Stephan Müller
2017-03-09 10:00 ` Herbert Xu [this message]
2017-03-09 10:02 ` Stephan Müller
2017-03-09 10:05 ` Herbert Xu
2017-03-09 10:08 ` Stephan Müller
2017-03-09 10:23 ` Herbert Xu
2017-03-09 10:27 ` Stephan Müller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170309100011.GA6844@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=smueller@chronox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).