From: Herbert Xu <herbert@gondor.apana.org.au>
To: Kees Cook <keescook@chromium.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Eric Biggers <ebiggers@google.com>,
linux-crypto <linux-crypto@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH crypto-next 00/23] crypto: skcipher - Remove VLA usage
Date: Fri, 28 Sep 2018 13:08:23 +0800 [thread overview]
Message-ID: <20180928050823.pggznhgv47wu4pd4@gondor.apana.org.au> (raw)
In-Reply-To: <20180919021100.3380-1-keescook@chromium.org>
On Tue, Sep 18, 2018 at 07:10:37PM -0700, Kees Cook wrote:
> This is the full follow-up to earlier discussions[1] that suggested
> adding a new struct crypto_sync_skcipher to handle the VLA removal from
> SKCIPHER_REQUEST_ON_STACK.
>
> This series is effectively a no-op change: everything is a wrapper
> around struct crypto_skcipher, but provides compile-time enforcement
> for not putting an ASYNC skcipher on the stack, which allows us to
> declare the on-stack requests with a fixed stack size.
>
> [1] https://lkml.kernel.org/r/CAGXu5j+bpLK=EQ9LHkO8V=sdaQwt==6fbGhgn2Vi1E9_WxSGRQ@mail.gmail.com
>
> -Kees
>
> Kees Cook (23):
> crypto: skcipher - Introduce crypto_sync_skcipher
> gss_krb5: Remove VLA usage of skcipher
> lib80211: Remove VLA usage of skcipher
> mac802154: Remove VLA usage of skcipher
> s390/crypto: Remove VLA usage of skcipher
> x86/fpu: Remove VLA usage of skcipher
> block: cryptoloop: Remove VLA usage of skcipher
> libceph: Remove VLA usage of skcipher
> ppp: mppe: Remove VLA usage of skcipher
> rxrpc: Remove VLA usage of skcipher
> wusb: Remove VLA usage of skcipher
> crypto: ccp - Remove VLA usage of skcipher
> crypto: vmx - Remove VLA usage of skcipher
> crypto: null - Remove VLA usage of skcipher
> crypto: cryptd - Remove VLA usage of skcipher
> crypto: sahara - Remove VLA usage of skcipher
> crypto: qce - Remove VLA usage of skcipher
> crypto: artpec6 - Remove VLA usage of skcipher
> crypto: chelsio - Remove VLA usage of skcipher
> crypto: mxs-dcp - Remove VLA usage of skcipher
> crypto: omap-aes - Remove VLA usage of skcipher
> crypto: picoxcell - Remove VLA usage of skcipher
> crypto: skcipher - Remove SKCIPHER_REQUEST_ON_STACK()
>
> arch/s390/crypto/aes_s390.c | 48 +++++-----
> arch/x86/crypto/fpu.c | 30 ++++---
> crypto/algif_aead.c | 12 +--
> crypto/authenc.c | 8 +-
> crypto/authencesn.c | 8 +-
> crypto/cryptd.c | 32 +++----
> crypto/crypto_null.c | 11 ++-
> crypto/echainiv.c | 4 +-
> crypto/gcm.c | 8 +-
> crypto/seqiv.c | 4 +-
> crypto/skcipher.c | 24 +++++
> drivers/block/cryptoloop.c | 22 ++---
> drivers/crypto/axis/artpec6_crypto.c | 19 ++--
> drivers/crypto/ccp/ccp-crypto-aes-xts.c | 13 +--
> drivers/crypto/ccp/ccp-crypto.h | 2 +-
> drivers/crypto/chelsio/chcr_algo.c | 27 +++---
> drivers/crypto/chelsio/chcr_crypto.h | 2 +-
> drivers/crypto/mxs-dcp.c | 21 +++--
> drivers/crypto/omap-aes.c | 17 ++--
> drivers/crypto/omap-aes.h | 2 +-
> drivers/crypto/picoxcell_crypto.c | 21 +++--
> drivers/crypto/qce/ablkcipher.c | 13 ++-
> drivers/crypto/qce/cipher.h | 2 +-
> drivers/crypto/sahara.c | 31 ++++---
> drivers/crypto/vmx/aes_cbc.c | 22 ++---
> drivers/crypto/vmx/aes_ctr.c | 18 ++--
> drivers/crypto/vmx/aes_xts.c | 18 ++--
> drivers/net/ppp/ppp_mppe.c | 27 +++---
> drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 34 ++++----
> drivers/staging/rtl8192e/rtllib_crypt_wep.c | 28 +++---
> .../rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 34 ++++----
> .../rtl8192u/ieee80211/ieee80211_crypt_wep.c | 26 +++---
> drivers/usb/wusbcore/crypto.c | 16 ++--
> include/crypto/internal/geniv.h | 2 +-
> include/crypto/null.h | 2 +-
> include/crypto/skcipher.h | 74 +++++++++++++++-
> include/linux/sunrpc/gss_krb5.h | 30 +++----
> net/ceph/crypto.c | 12 +--
> net/ceph/crypto.h | 2 +-
> net/mac802154/llsec.c | 16 ++--
> net/mac802154/llsec.h | 2 +-
> net/rxrpc/ar-internal.h | 2 +-
> net/rxrpc/rxkad.c | 44 +++++-----
> net/sunrpc/auth_gss/gss_krb5_crypto.c | 87 ++++++++++---------
> net/sunrpc/auth_gss/gss_krb5_keys.c | 9 +-
> net/sunrpc/auth_gss/gss_krb5_mech.c | 53 ++++++-----
> net/sunrpc/auth_gss/gss_krb5_seqnum.c | 18 ++--
> net/sunrpc/auth_gss/gss_krb5_wrap.c | 20 ++---
> net/wireless/lib80211_crypt_tkip.c | 34 ++++----
> net/wireless/lib80211_crypt_wep.c | 28 +++---
> 50 files changed, 563 insertions(+), 476 deletions(-)
All applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2018-09-28 5:08 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 2:10 [PATCH crypto-next 00/23] crypto: skcipher - Remove VLA usage Kees Cook
2018-09-19 2:10 ` [PATCH crypto-next 01/23] crypto: skcipher - Introduce crypto_sync_skcipher Kees Cook
2018-09-24 11:48 ` Ard Biesheuvel
2018-09-19 2:10 ` [PATCH crypto-next 02/23] gss_krb5: Remove VLA usage of skcipher Kees Cook
2018-09-19 2:10 ` [PATCH crypto-next 03/23] lib80211: " Kees Cook
2018-09-19 20:37 ` Johannes Berg
2018-09-19 2:10 ` [PATCH crypto-next 04/23] mac802154: " Kees Cook
2018-09-19 2:10 ` [PATCH crypto-next 05/23] s390/crypto: " Kees Cook
2018-09-19 2:10 ` [PATCH crypto-next 06/23] x86/fpu: " Kees Cook
2018-09-24 11:45 ` Ard Biesheuvel
2018-09-24 17:35 ` Kees Cook
2018-09-19 2:10 ` [PATCH crypto-next 07/23] block: cryptoloop: " Kees Cook
2018-09-24 11:52 ` Ard Biesheuvel
2018-09-24 17:53 ` Kees Cook
2018-09-25 9:25 ` Ard Biesheuvel
2018-09-25 16:03 ` Jens Axboe
2018-09-25 16:16 ` Ard Biesheuvel
2018-09-25 16:32 ` Jens Axboe
2018-09-26 8:19 ` Ard Biesheuvel
2018-09-19 2:10 ` [PATCH crypto-next 08/23] libceph: " Kees Cook
2018-09-19 2:10 ` [PATCH crypto-next 09/23] ppp: mppe: " Kees Cook
2018-09-19 2:10 ` [PATCH crypto-next 10/23] rxrpc: " Kees Cook
2018-09-19 2:10 ` [PATCH crypto-next 11/23] wusb: " Kees Cook
2018-09-20 10:39 ` Greg Kroah-Hartman
2018-09-19 2:10 ` [PATCH crypto-next 12/23] crypto: ccp - " Kees Cook
2018-09-19 2:10 ` [PATCH crypto-next 13/23] crypto: vmx " Kees Cook
2018-09-19 2:10 ` [PATCH crypto-next 14/23] crypto: null " Kees Cook
2018-09-19 2:10 ` [PATCH crypto-next 15/23] crypto: cryptd " Kees Cook
2018-09-19 2:10 ` [PATCH crypto-next 16/23] crypto: sahara " Kees Cook
2018-09-19 2:10 ` [PATCH crypto-next 17/23] crypto: qce " Kees Cook
2018-09-19 2:10 ` [PATCH crypto-next 18/23] crypto: artpec6 " Kees Cook
2018-09-23 12:13 ` Lars Persson
2018-09-19 2:10 ` [PATCH crypto-next 19/23] crypto: chelsio " Kees Cook
2018-09-19 2:10 ` [PATCH crypto-next 20/23] crypto: mxs-dcp " Kees Cook
2018-09-19 2:10 ` [PATCH crypto-next 21/23] crypto: omap-aes " Kees Cook
2018-09-19 2:10 ` [PATCH crypto-next 22/23] crypto: picoxcell " Kees Cook
2018-09-19 2:11 ` [PATCH crypto-next 23/23] crypto: skcipher - Remove SKCIPHER_REQUEST_ON_STACK() Kees Cook
2018-09-25 0:49 ` [PATCH crypto-next 00/23] crypto: skcipher - Remove VLA usage Kees Cook
2018-09-25 4:49 ` Herbert Xu
2018-09-25 15:39 ` Kees Cook
2018-09-28 5:08 ` Herbert Xu [this message]
2018-09-28 16:13 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180928050823.pggznhgv47wu4pd4@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ard.biesheuvel@linaro.org \
--cc=ebiggers@google.com \
--cc=keescook@chromium.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).