linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Eric Biggers <ebiggers@kernel.org>
Cc: ltp@lists.linux.it, linux-crypto@vger.kernel.org
Subject: Re: [LTP] [PATCH 2/6] crypto/af_alg01: new regression test for hmac nesting bug
Date: Fri, 15 Mar 2019 10:43:08 +0100	[thread overview]
Message-ID: <20190315094308.GC4990@dell5510> (raw)
In-Reply-To: <20190221053026.18489-3-ebiggers@kernel.org>

Hi Eric,

> +static void run(void)
> +{
> +	/* try several different unkeyed hash algorithms */
> +	static const char * const hash_algs[] = {
> +		"md5", "md5-generic",
> +		"sha1", "sha1-generic",
> +		"sha224", "sha224-generic",
> +		"sha256", "sha256-generic",
> +		"sha3-256", "sha3-256-generic",
> +		"sha3-512", "sha3-512-generic",
> +	};
> +	size_t i;
FYI: We usually use struct tcase with .tcnt = ARRAY_SIZE(tcases)
instead of for loop, but it's only a minor detail.

> +
> +	for (i = 0; i < ARRAY_SIZE(hash_algs); i++)
> +		test_with_hash_alg(hash_algs[i]);
> +}
> +
> +static struct tst_test test = {
> +	.test_all = run,
> +};


Kind regards,
Petr

  reply	other threads:[~2019-03-15  9:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-21  5:30 [PATCH 0/6] ltp: AF_ALG test helpers and a few regression tests Eric Biggers
2019-02-21  5:30 ` [PATCH 1/6] lib: add tst_af_alg lib Eric Biggers
2019-03-15  9:38   ` [LTP] " Petr Vorel
2019-02-21  5:30 ` [PATCH 2/6] crypto/af_alg01: new regression test for hmac nesting bug Eric Biggers
2019-03-15  9:43   ` Petr Vorel [this message]
2019-02-21  5:30 ` [PATCH 3/6] crypto/af_alg02: new regression test for salsa20 empty message bug Eric Biggers
2019-02-21  5:30 ` [PATCH 4/6] crypto/af_alg03: new regression test for rfc7539 hash alg validation Eric Biggers
2019-03-15  9:29   ` [LTP] " Petr Vorel
2019-03-15 16:13     ` Eric Biggers
2019-03-15 18:40       ` Petr Vorel
2019-03-15 19:49         ` Eric Biggers
2019-02-21  5:30 ` [PATCH 5/6] crypto/af_alg04: new regression test for vmac race conditions Eric Biggers
2019-02-21  5:30 ` [PATCH 6/6] crypto/af_alg05: new regression test for skcipher_walk error bug Eric Biggers
2019-03-15  0:11 ` [PATCH 0/6] ltp: AF_ALG test helpers and a few regression tests Eric Biggers
2019-03-15  9:45 ` [LTP] " Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190315094308.GC4990@dell5510 \
    --to=pvorel@suse.cz \
    --cc=ebiggers@kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).