From: Herbert Xu <herbert@gondor.apana.org.au>
To: Vakul Garg <vakul.garg@nxp.com>
Cc: "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
Horia Geanta <horia.geanta@nxp.com>,
Aymen Sghaier <aymen.sghaier@nxp.com>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH v3] crypto: caam/jr - optimize job ring enqueue and dequeue operations
Date: Fri, 22 Mar 2019 21:02:57 +0800 [thread overview]
Message-ID: <20190322130257.drdgj7ym4z7e6exl@gondor.apana.org.au> (raw)
In-Reply-To: <20190305180040.8860-1-vakul.garg@nxp.com>
On Tue, Mar 05, 2019 at 06:03:14PM +0000, Vakul Garg wrote:
> Instead of reading job ring's occupancy registers for every req/rsp
> enqueued/dequeued respectively, we read these registers once and store
> them in memory. After completing a job enqueue/dequeue, we decrement
> these values. When these values become zero, we refresh the snapshot of
> job ring's occupancy registers. This eliminates need of expensive device
> register read operations for every job enqueued and dequeued and hence
> makes caam_jr_enqueue() and caam_jr_dequeue() faster. The performance of
> kernel ipsec improved by about 6% on ls1028 (for frame size 408 bytes).
>
> Signed-off-by: Vakul Garg <vakul.garg@nxp.com>
> ---
>
> Changes since v2:
> - Added magnitude of performance improvement in commit log.
>
> drivers/crypto/caam/intern.h | 1 +
> drivers/crypto/caam/jr.c | 12 ++++++++++--
> 2 files changed, 11 insertions(+), 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2019-03-22 13:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 18:03 [PATCH v3] crypto: caam/jr - optimize job ring enqueue and dequeue operations Vakul Garg
2019-03-05 18:34 ` Horia Geanta
2019-03-22 13:02 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190322130257.drdgj7ym4z7e6exl@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=aymen.sghaier@nxp.com \
--cc=davem@davemloft.net \
--cc=horia.geanta@nxp.com \
--cc=linux-crypto@vger.kernel.org \
--cc=vakul.garg@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).