From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EAB4C43381 for ; Fri, 22 Mar 2019 13:04:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EC7452075E for ; Fri, 22 Mar 2019 13:04:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730587AbfCVNEo (ORCPT ); Fri, 22 Mar 2019 09:04:44 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:49510 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731292AbfCVNEo (ORCPT ); Fri, 22 Mar 2019 09:04:44 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1h7Jqi-0006Jt-Hb; Fri, 22 Mar 2019 21:04:40 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1h7Jqi-0005fg-Dn; Fri, 22 Mar 2019 21:04:40 +0800 Date: Fri, 22 Mar 2019 21:04:40 +0800 From: Herbert Xu To: Eric Biggers Cc: linux-crypto@vger.kernel.org Subject: Re: [PATCH] crypto: chacha-generic - use crypto_xor_cpy() Message-ID: <20190322130440.xy6jkpyywtpnwfel@gondor.apana.org.au> References: <20190315042037.32297-1-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190315042037.32297-1-ebiggers@kernel.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Mar 14, 2019 at 09:20:36PM -0700, Eric Biggers wrote: > From: Eric Biggers > > In chacha_docrypt(), use crypto_xor_cpy() instead of crypto_xor(). > This avoids having to memcpy() the src buffer to the dst buffer. > > Signed-off-by: Eric Biggers > --- > crypto/chacha_generic.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt