From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71FCBC04AAC for ; Thu, 23 May 2019 06:52:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3D1852133D for ; Thu, 23 May 2019 06:52:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725873AbfEWGwU (ORCPT ); Thu, 23 May 2019 02:52:20 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:47802 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725806AbfEWGwU (ORCPT ); Thu, 23 May 2019 02:52:20 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1hThaN-0001pq-G1; Thu, 23 May 2019 14:52:19 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1hThaL-0006CV-L7; Thu, 23 May 2019 14:52:17 +0800 Date: Thu, 23 May 2019 14:52:17 +0800 From: Herbert Xu To: Sascha Hauer Cc: linux-crypto@vger.kernel.org, Horia =?utf-8?Q?Geant=C4=83?= , kernel@pengutronix.de Subject: Re: [PATCH] crypto: caam - print debugging hex dumps after unmapping Message-ID: <20190523065217.7zf7vqf6zbbit6oo@gondor.apana.org.au> References: <20190516142442.32537-1-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190516142442.32537-1-s.hauer@pengutronix.de> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, May 16, 2019 at 04:24:42PM +0200, Sascha Hauer wrote: > For encryption the destination pointer was still mapped, so the hex dump > may be wrong. The IV still contained the input IV while printing instead > of the output IV as intended. > > For decryption the destination pointer was still mapped, so the hex dump > may be wrong. The IV dump was correct. > > Do the hex dumps consistenly after the buffers have been unmapped and > in case of IV copied to their final destination. > > Signed-off-by: Sascha Hauer > Reviewed-by: Horia Geantă > --- > drivers/crypto/caam/caamalg.c | 21 +++++++++++---------- > 1 file changed, 11 insertions(+), 10 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt