From: "Michal Suchánek" <msuchanek@suse.de>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-crypto@vger.kernel.org, chetjain@in.ibm.com,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: algapi - guard against uninitialized spawn list in crypto_remove_spawns
Date: Tue, 25 Jun 2019 18:48:48 +0200 [thread overview]
Message-ID: <20190625184848.1b2e5dfe@kitsune.suse.cz> (raw)
In-Reply-To: <20190625164052.GA81914@gmail.com>
On Tue, 25 Jun 2019 09:40:54 -0700
Eric Biggers <ebiggers@kernel.org> wrote:
Hello,
> Hi Michal,
>
> The stack trace shows that crypto_remove_spawns() is being called from
> crypto_unregister_instance(). Therefore, the instance should already be
> registered and have initialized cra_users. Now, I don't claim to understand the
> spawn lists stuff that well, so I could have missed something; but if there *is*
> a bug, I'd like to see a proper explanation.
Unfortunately, I don't have an explanation either.
>
> Did you check whether this is actually reproducible on mainline, and not just
> the SUSE v4.12 based kernel?
Mainline crashes on boot:/
Need to find a recent working kernel.
Thanks
Michal
next prev parent reply other threads:[~2019-06-25 16:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 7:16 [PATCH] crypto: algapi - guard against uninitialized spawn list in crypto_remove_spawns Michal Suchanek
2019-06-25 16:40 ` Eric Biggers
2019-06-25 16:48 ` Michal Suchánek [this message]
2019-07-01 13:31 ` Michal Suchánek
2019-07-02 21:17 ` [PATCH] crypto: user - prevent operating on larval algorithms Eric Biggers
2019-07-03 14:30 ` Herbert Xu
2019-07-03 20:21 ` Michal Suchánek
2019-07-03 20:31 ` Eric Biggers
2019-07-03 21:10 ` Michal Suchánek
2019-07-02 22:11 ` [PATCH] crypto: algapi - guard against uninitialized spawn list in crypto_remove_spawns Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625184848.1b2e5dfe@kitsune.suse.cz \
--to=msuchanek@suse.de \
--cc=chetjain@in.ibm.com \
--cc=davem@davemloft.net \
--cc=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).