From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E9C6C433FF for ; Mon, 29 Jul 2019 20:08:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F2CB82064C for ; Mon, 29 Jul 2019 20:08:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564430937; bh=35ZwmfXjVkjcTD49ueQekrtcYmxgdRwDGATcxQouXLg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=AGvIT1uPf/ukmF+auzbxJAJo5rajzg34UPcrmxtJutSc7wg/zF3mjBS/MEuCXfqyh pp5OXYjZk6HoYTQWOgrDYoxWI1CpF++bCxFOXp2vdJHFdV4tIxrDiEm1IE8PTLy8At ZTlXziSar1CBS3B+7Mztt7yVNNxAhuFm8wRSiCvY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388755AbfG2Thp (ORCPT ); Mon, 29 Jul 2019 15:37:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:52608 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388750AbfG2Tho (ORCPT ); Mon, 29 Jul 2019 15:37:44 -0400 Received: from gmail.com (unknown [104.132.1.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6E126206DD; Mon, 29 Jul 2019 19:37:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564429063; bh=35ZwmfXjVkjcTD49ueQekrtcYmxgdRwDGATcxQouXLg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QgTCz2CWqZ9GLFMzgaQtbnyPki0Oxg8qrvTR97l00Gc8CQzx+zc2oXmp7EWb24DL7 lqI1c/qw8hCySTW9XZjhkJGofi5da7NFa4tbNNzKq3SlAVuvZteu0lZkG1ZnucaL4j QUyqoTdTCGY36VS+Fv9/JDNLvuGsN+DnFosM0q6c= Date: Mon, 29 Jul 2019 12:37:42 -0700 From: Eric Biggers To: "Theodore Y. Ts'o" Cc: linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org, linux-api@vger.kernel.org, linux-crypto@vger.kernel.org, keyrings@vger.kernel.org, Paul Crowley , Satya Tangirala Subject: Re: [PATCH v7 05/16] fscrypt: refactor v1 policy key setup into keysetup_legacy.c Message-ID: <20190729193740.GD169027@gmail.com> Mail-Followup-To: "Theodore Y. Ts'o" , linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org, linux-api@vger.kernel.org, linux-crypto@vger.kernel.org, keyrings@vger.kernel.org, Paul Crowley , Satya Tangirala References: <20190726224141.14044-1-ebiggers@kernel.org> <20190726224141.14044-6-ebiggers@kernel.org> <20190728154032.GE6088@mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190728154032.GE6088@mit.edu> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Hi Ted, thanks for the review! On Sun, Jul 28, 2019 at 11:40:32AM -0400, Theodore Y. Ts'o wrote: > On Fri, Jul 26, 2019 at 03:41:30PM -0700, Eric Biggers wrote: > > From: Eric Biggers > > > > In preparation for introducing v2 encryption policies which will find > > and derive encryption keys differently from the current v1 encryption > > policies, refactor the v1 policy-specific key setup code from keyinfo.c > > into keysetup_legacy.c. Then rename keyinfo.c to keysetup.c. > > I'd use keysetup_v1.c, myself. We can hope that we've gotten it right > with v2 and we'll never need to do another version, but *something* is > going to come up eventually which will require a v3 keysetup , whether > it's post-quantuum cryptography or something else we can't anticipate > right now. > > For an example of the confusion that can result, one good example is > in the fs/quota subsystem, where QFMT_VFS_OLD, QFMT_VFS_V0, and > QFMT_VFS_V1 maps to quota_v1 and quota_v2 in an amusing and > non-obvious way. (Go ahead, try to guess before you go look at the > code. :-) > > Other than that, looks good. We can always move code around or rename > files in the future, so I'm not going to insist on doing it now (but > it would be my preference). > > Reviewed-by: Theodore Ts'o > Agreed, I'll call it keysetup_v1.c instead. - Eric