From: Kees Cook <keescook@chromium.org>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: ux500/crypt: Mark expected switch fall-throughs
Date: Tue, 30 Jul 2019 09:58:01 -0700 [thread overview]
Message-ID: <201907300958.55BF0AD@keescook> (raw)
In-Reply-To: <20190729223819.GA21985@embeddedor>
On Mon, Jul 29, 2019 at 05:38:19PM -0500, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warning (Building: arm):
>
> drivers/crypto/ux500/cryp/cryp.c: In function ‘cryp_save_device_context’:
> drivers/crypto/ux500/cryp/cryp.c:316:16: warning: this statement may fall through [-Wimplicit-fallthrough=]
> ctx->key_4_r = readl_relaxed(&src_reg->key_4_r);
> drivers/crypto/ux500/cryp/cryp.c:318:2: note: here
> case CRYP_KEY_SIZE_192:
> ^~~~
> drivers/crypto/ux500/cryp/cryp.c:320:16: warning: this statement may fall through [-Wimplicit-fallthrough=]
> ctx->key_3_r = readl_relaxed(&src_reg->key_3_r);
> drivers/crypto/ux500/cryp/cryp.c:322:2: note: here
> case CRYP_KEY_SIZE_128:
> ^~~~
> drivers/crypto/ux500/cryp/cryp.c:324:16: warning: this statement may fall through [-Wimplicit-fallthrough=]
> ctx->key_2_r = readl_relaxed(&src_reg->key_2_r);
> drivers/crypto/ux500/cryp/cryp.c:326:2: note: here
> default:
> ^~~~~~~
> In file included from ./include/linux/io.h:13:0,
> from drivers/crypto/ux500/cryp/cryp_p.h:14,
> from drivers/crypto/ux500/cryp/cryp.c:15:
> drivers/crypto/ux500/cryp/cryp.c: In function ‘cryp_restore_device_context’:
> ./arch/arm/include/asm/io.h:92:22: warning: this statement may fall through [-Wimplicit-fallthrough=]
> #define __raw_writel __raw_writel
> ^
> ./arch/arm/include/asm/io.h:299:29: note: in expansion of macro ‘__raw_writel’
> #define writel_relaxed(v,c) __raw_writel((__force u32) cpu_to_le32(v),c)
> ^~~~~~~~~~~~
> drivers/crypto/ux500/cryp/cryp.c:363:3: note: in expansion of macro ‘writel_relaxed’
> writel_relaxed(ctx->key_4_r, ®->key_4_r);
> ^~~~~~~~~~~~~~
> drivers/crypto/ux500/cryp/cryp.c:365:2: note: here
> case CRYP_KEY_SIZE_192:
> ^~~~
> In file included from ./include/linux/io.h:13:0,
> from drivers/crypto/ux500/cryp/cryp_p.h:14,
> from drivers/crypto/ux500/cryp/cryp.c:15:
> ./arch/arm/include/asm/io.h:92:22: warning: this statement may fall through [-Wimplicit-fallthrough=]
> #define __raw_writel __raw_writel
> ^
> ./arch/arm/include/asm/io.h:299:29: note: in expansion of macro ‘__raw_writel’
> #define writel_relaxed(v,c) __raw_writel((__force u32) cpu_to_le32(v),c)
> ^~~~~~~~~~~~
> drivers/crypto/ux500/cryp/cryp.c:367:3: note: in expansion of macro ‘writel_relaxed’
> writel_relaxed(ctx->key_3_r, ®->key_3_r);
> ^~~~~~~~~~~~~~
> drivers/crypto/ux500/cryp/cryp.c:369:2: note: here
> case CRYP_KEY_SIZE_128:
> ^~~~
> In file included from ./include/linux/io.h:13:0,
> from drivers/crypto/ux500/cryp/cryp_p.h:14,
> from drivers/crypto/ux500/cryp/cryp.c:15:
> ./arch/arm/include/asm/io.h:92:22: warning: this statement may fall through [-Wimplicit-fallthrough=]
> #define __raw_writel __raw_writel
> ^
> ./arch/arm/include/asm/io.h:299:29: note: in expansion of macro ‘__raw_writel’
> #define writel_relaxed(v,c) __raw_writel((__force u32) cpu_to_le32(v),c)
> ^~~~~~~~~~~~
> drivers/crypto/ux500/cryp/cryp.c:371:3: note: in expansion of macro ‘writel_relaxed’
> writel_relaxed(ctx->key_2_r, ®->key_2_r);
> ^~~~~~~~~~~~~~
> drivers/crypto/ux500/cryp/cryp.c:373:2: note: here
> default:
> ^~~~~~~
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
> ---
> drivers/crypto/ux500/cryp/cryp.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/crypto/ux500/cryp/cryp.c b/drivers/crypto/ux500/cryp/cryp.c
> index ece83a363e11..f22f6fa612b3 100644
> --- a/drivers/crypto/ux500/cryp/cryp.c
> +++ b/drivers/crypto/ux500/cryp/cryp.c
> @@ -314,14 +314,17 @@ void cryp_save_device_context(struct cryp_device_data *device_data,
> case CRYP_KEY_SIZE_256:
> ctx->key_4_l = readl_relaxed(&src_reg->key_4_l);
> ctx->key_4_r = readl_relaxed(&src_reg->key_4_r);
> + /* Fall through */
>
> case CRYP_KEY_SIZE_192:
> ctx->key_3_l = readl_relaxed(&src_reg->key_3_l);
> ctx->key_3_r = readl_relaxed(&src_reg->key_3_r);
> + /* Fall through */
>
> case CRYP_KEY_SIZE_128:
> ctx->key_2_l = readl_relaxed(&src_reg->key_2_l);
> ctx->key_2_r = readl_relaxed(&src_reg->key_2_r);
> + /* Fall through */
>
> default:
> ctx->key_1_l = readl_relaxed(&src_reg->key_1_l);
> @@ -361,14 +364,17 @@ void cryp_restore_device_context(struct cryp_device_data *device_data,
> case CRYP_KEY_SIZE_256:
> writel_relaxed(ctx->key_4_l, ®->key_4_l);
> writel_relaxed(ctx->key_4_r, ®->key_4_r);
> + /* Fall through */
>
> case CRYP_KEY_SIZE_192:
> writel_relaxed(ctx->key_3_l, ®->key_3_l);
> writel_relaxed(ctx->key_3_r, ®->key_3_r);
> + /* Fall through */
>
> case CRYP_KEY_SIZE_128:
> writel_relaxed(ctx->key_2_l, ®->key_2_l);
> writel_relaxed(ctx->key_2_r, ®->key_2_r);
> + /* Fall through */
>
> default:
> writel_relaxed(ctx->key_1_l, ®->key_1_l);
> --
> 2.22.0
>
--
Kees Cook
next prev parent reply other threads:[~2019-07-30 16:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 22:38 [PATCH] crypto: ux500/crypt: Mark expected switch fall-throughs Gustavo A. R. Silva
2019-07-30 16:58 ` Kees Cook [this message]
2019-08-09 6:10 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201907300958.55BF0AD@keescook \
--to=keescook@chromium.org \
--cc=davem@davemloft.net \
--cc=gustavo@embeddedor.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).