From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18CC5C32750 for ; Fri, 2 Aug 2019 17:31:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E282C217D6 for ; Fri, 2 Aug 2019 17:31:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564767114; bh=p28pesjeaFELdMWXTRb2eE2TRQRtp76oeifvbyCl/RI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=rFwws+nthjllcdAQcahS5txVsHJLnTGIgFfBogouOSZ+COzUWLZ1t7ZW4qKuSvK96 T1x59tWNb2XuFj8aP9xXQKL01cgzy8v05IMOmYuPcaVDJif34Ix2RqXP+Pl+Phx4U3 CUYCEiQwEe5gEycZD/C/ZOEmayuhxIeLa6YbxWOo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405292AbfHBRbw (ORCPT ); Fri, 2 Aug 2019 13:31:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:46482 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405145AbfHBRbw (ORCPT ); Fri, 2 Aug 2019 13:31:52 -0400 Received: from gmail.com (unknown [104.132.1.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 31C1B2173E; Fri, 2 Aug 2019 17:31:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1564767111; bh=p28pesjeaFELdMWXTRb2eE2TRQRtp76oeifvbyCl/RI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZcqdJ1sHgA4eHoVKYSn8SpVn+pAUEpj9uFNNG8Yop5svyGIeSKgDaCG0hU7/1xGe+ YH6wiSFmAifvQSIcT5ECPJSv2MxBpI4U1tOb0SI7k4tFkU4lU056T/wtL7OaDANFff AXFhYpVcepiXq7WKPEIqg6WGV1t6hc/k/rdkPvQU= Date: Fri, 2 Aug 2019 10:31:49 -0700 From: Eric Biggers To: Chao Yu Cc: linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org, linux-api@vger.kernel.org, linux-crypto@vger.kernel.org, keyrings@vger.kernel.org, Paul Crowley , Satya Tangirala Subject: Re: [PATCH v7 14/16] f2fs: wire up new fscrypt ioctls Message-ID: <20190802173148.GA51937@gmail.com> Mail-Followup-To: Chao Yu , linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org, linux-api@vger.kernel.org, linux-crypto@vger.kernel.org, keyrings@vger.kernel.org, Paul Crowley , Satya Tangirala References: <20190726224141.14044-1-ebiggers@kernel.org> <20190726224141.14044-15-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Aug 02, 2019 at 04:10:15PM +0800, Chao Yu wrote: > Hi Eric, > > On 2019/7/27 6:41, Eric Biggers wrote: > > From: Eric Biggers > > > > Wire up the new ioctls for adding and removing fscrypt keys to/from the > > filesystem, and the new ioctl for retrieving v2 encryption policies. > > > > FS_IOC_REMOVE_ENCRYPTION_KEY also required making f2fs_drop_inode() call > > fscrypt_drop_inode(). > > > > For more details see Documentation/filesystems/fscrypt.rst and the > > fscrypt patches that added the implementation of these ioctls. > > > > Signed-off-by: Eric Biggers > > Reviewed-by: Chao Yu > > BTW, do you think it needs to make xxfs_has_support_encrypt() function be a > common interface defined in struct fscrypt_operations, as I see all > fscrypt_ioctl_*() needs to check with it, tho such cleanup is minor... > Maybe. It would work nicely for ext4 and f2fs, but ubifs does things differently since it automatically enables the encryption feature if needed. So we'd have to make the callback optional. In any case, I think this should be separate from this patchset. - Eric