From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCFE0C433FF for ; Fri, 9 Aug 2019 15:04:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A8E6020B7C for ; Fri, 9 Aug 2019 15:04:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406503AbfHIPEt (ORCPT ); Fri, 9 Aug 2019 11:04:49 -0400 Received: from vmicros1.altlinux.org ([194.107.17.57]:35172 "EHLO vmicros1.altlinux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726328AbfHIPEt (ORCPT ); Fri, 9 Aug 2019 11:04:49 -0400 Received: from imap.altlinux.org (imap.altlinux.org [194.107.17.38]) by vmicros1.altlinux.org (Postfix) with ESMTP id A7B0872CCE6; Fri, 9 Aug 2019 18:04:45 +0300 (MSK) Received: from altlinux.org (sole.flsd.net [185.75.180.6]) by imap.altlinux.org (Postfix) with ESMTPSA id 9707F4A4AFB; Fri, 9 Aug 2019 18:04:45 +0300 (MSK) Date: Fri, 9 Aug 2019 18:04:45 +0300 From: Vitaly Chikunov To: YueHaibing Cc: herbert@gondor.apana.org.au, davem@davemloft.net, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org Subject: Re: [PATCH -next] crypto: streebog - remove two unused variables Message-ID: <20190809150445.34keqaxdkvy4qg7f@altlinux.org> Mail-Followup-To: YueHaibing , herbert@gondor.apana.org.au, davem@davemloft.net, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org References: <20190809084905.69444-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20190809084905.69444-1-yuehaibing@huawei.com> User-Agent: NeoMutt/20171215-106-ac61c7 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Aug 09, 2019 at 04:49:05PM +0800, YueHaibing wrote: > crypto/streebog_generic.c:162:17: warning: > Pi defined but not used [-Wunused-const-variable=] > crypto/streebog_generic.c:151:17: warning: > Tau defined but not used [-Wunused-const-variable=] > > They are never used, so can be removed. > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing Reviewed-by: Vitaly Chikunov > --- > crypto/streebog_generic.c | 46 ---------------------------------------------- > 1 file changed, 46 deletions(-) > > diff --git a/crypto/streebog_generic.c b/crypto/streebog_generic.c > index 63663c3..dc625ff 100644 > --- a/crypto/streebog_generic.c > +++ b/crypto/streebog_generic.c > @@ -148,52 +148,6 @@ static const struct streebog_uint512 C[12] = { > } } > }; > > -static const u8 Tau[64] = { > - 0, 8, 16, 24, 32, 40, 48, 56, > - 1, 9, 17, 25, 33, 41, 49, 57, > - 2, 10, 18, 26, 34, 42, 50, 58, > - 3, 11, 19, 27, 35, 43, 51, 59, > - 4, 12, 20, 28, 36, 44, 52, 60, > - 5, 13, 21, 29, 37, 45, 53, 61, > - 6, 14, 22, 30, 38, 46, 54, 62, > - 7, 15, 23, 31, 39, 47, 55, 63 > -}; > - > -static const u8 Pi[256] = { > - 252, 238, 221, 17, 207, 110, 49, 22, > - 251, 196, 250, 218, 35, 197, 4, 77, > - 233, 119, 240, 219, 147, 46, 153, 186, > - 23, 54, 241, 187, 20, 205, 95, 193, > - 249, 24, 101, 90, 226, 92, 239, 33, > - 129, 28, 60, 66, 139, 1, 142, 79, > - 5, 132, 2, 174, 227, 106, 143, 160, > - 6, 11, 237, 152, 127, 212, 211, 31, > - 235, 52, 44, 81, 234, 200, 72, 171, > - 242, 42, 104, 162, 253, 58, 206, 204, > - 181, 112, 14, 86, 8, 12, 118, 18, > - 191, 114, 19, 71, 156, 183, 93, 135, > - 21, 161, 150, 41, 16, 123, 154, 199, > - 243, 145, 120, 111, 157, 158, 178, 177, > - 50, 117, 25, 61, 255, 53, 138, 126, > - 109, 84, 198, 128, 195, 189, 13, 87, > - 223, 245, 36, 169, 62, 168, 67, 201, > - 215, 121, 214, 246, 124, 34, 185, 3, > - 224, 15, 236, 222, 122, 148, 176, 188, > - 220, 232, 40, 80, 78, 51, 10, 74, > - 167, 151, 96, 115, 30, 0, 98, 68, > - 26, 184, 56, 130, 100, 159, 38, 65, > - 173, 69, 70, 146, 39, 94, 85, 47, > - 140, 163, 165, 125, 105, 213, 149, 59, > - 7, 88, 179, 64, 134, 172, 29, 247, > - 48, 55, 107, 228, 136, 217, 231, 137, > - 225, 27, 131, 73, 76, 63, 248, 254, > - 141, 83, 170, 144, 202, 216, 133, 97, > - 32, 113, 103, 164, 45, 43, 9, 91, > - 203, 155, 37, 208, 190, 229, 108, 82, > - 89, 166, 116, 210, 230, 244, 180, 192, > - 209, 102, 175, 194, 57, 75, 99, 182 > -}; > - > static const unsigned long long Ax[8][256] = { > { > 0xd01f715b5c7ef8e6ULL, 0x16fa240980778325ULL, 0xa8a42e857ee049c8ULL, > -- > 2.7.4 >