From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76338C32757 for ; Mon, 12 Aug 2019 22:20:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 47DD520820 for ; Mon, 12 Aug 2019 22:20:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726632AbfHLWUa (ORCPT ); Mon, 12 Aug 2019 18:20:30 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:37518 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726488AbfHLWU3 (ORCPT ); Mon, 12 Aug 2019 18:20:29 -0400 Received: from callcc.thunk.org (guestnat-104-133-9-109.corp.google.com [104.133.9.109] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x7CMK4AQ010100 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 12 Aug 2019 18:20:06 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id F054A4218EF; Mon, 12 Aug 2019 18:20:03 -0400 (EDT) Date: Mon, 12 Aug 2019 18:20:03 -0400 From: "Theodore Y. Ts'o" To: Eric Biggers Cc: linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-crypto@vger.kernel.org, keyrings@vger.kernel.org, linux-api@vger.kernel.org, Satya Tangirala , Paul Crowley , Jaegeuk Kim Subject: Re: [PATCH v8 05/20] fscrypt: rename fscrypt_master_key to fscrypt_direct_key Message-ID: <20190812222003.GD28705@mit.edu> References: <20190805162521.90882-1-ebiggers@kernel.org> <20190805162521.90882-6-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190805162521.90882-6-ebiggers@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, Aug 05, 2019 at 09:25:06AM -0700, Eric Biggers wrote: > From: Eric Biggers > > In preparation for introducing a filesystem-level keyring which will > contain fscrypt master keys, rename the existing 'struct > fscrypt_master_key' to 'struct fscrypt_direct_key'. This is the > structure in the existing table of master keys that's maintained to > deduplicate the crypto transforms for v1 DIRECT_KEY policies. > > I've chosen to keep this table as-is rather than make it automagically > add/remove the keys to/from the filesystem-level keyring, since that > would add a lot of extra complexity to the filesystem-level keyring. > > Signed-off-by: Eric Biggers Looks good. You can add: Reviewed-by: Theodore Ts'o - Ted