From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E7FDC32750 for ; Tue, 13 Aug 2019 18:00:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EBB082064A for ; Tue, 13 Aug 2019 18:00:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565719229; bh=xbId40i8Dmjn2QpQ5F72v+idr4xKL+uiDE3bps/IbM8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=yuO/CtR0yA9OXX1jX4cklmp0lpWy23umMGtQWy9zWBbh7WdnlSonLby4sP8whv2/k +gj0IQIhl7rbemAkCbb3si1A6/Oy7ALh5sTrl6ksYde4fw2/lJLZ9h5j6FRpr4F0Dc KdB6X1TSSHiz/JfB8ZXf9pq6BEWArMmL0cgUVqPo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728273AbfHMSAY (ORCPT ); Tue, 13 Aug 2019 14:00:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:55908 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728183AbfHMSAY (ORCPT ); Tue, 13 Aug 2019 14:00:24 -0400 Received: from gmail.com (unknown [104.132.1.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3EA692064A; Tue, 13 Aug 2019 18:00:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565719223; bh=xbId40i8Dmjn2QpQ5F72v+idr4xKL+uiDE3bps/IbM8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BayrdhFEfQMICZuff9kc8Zczn1zZKbpC1zN4w2uSaXqUVlPSOnGX3eT3XDZboDZ5I AMgS6M/AAct+38Y+zPdoNsuNtrqDboYb831ILAwZrjxkMTrQBG54x3arFtyaQ/mgsS 1QSpuT+ktcVAeodm5b+IgGs4to2MdOKn9sa2bAqc= Date: Tue, 13 Aug 2019 11:00:21 -0700 From: Eric Biggers To: Ard Biesheuvel Cc: "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Herbert Xu , device-mapper development , linux-fscrypt@vger.kernel.org, Gilad Ben-Yossef , Milan Broz Subject: Re: [dm-devel] [PATCH v10 2/7] fs: crypto: invoke crypto API for ESSIV handling Message-ID: <20190813180020.GA233786@gmail.com> Mail-Followup-To: Ard Biesheuvel , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Herbert Xu , device-mapper development , linux-fscrypt@vger.kernel.org, Gilad Ben-Yossef , Milan Broz References: <20190812145324.27090-1-ard.biesheuvel@linaro.org> <20190812145324.27090-3-ard.biesheuvel@linaro.org> <20190812194747.GB131059@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Aug 13, 2019 at 08:09:41AM +0300, Ard Biesheuvel wrote: > On Mon, 12 Aug 2019 at 22:47, Eric Biggers wrote: > > > > On Mon, Aug 12, 2019 at 05:53:19PM +0300, Ard Biesheuvel wrote: > > > Instead of open coding the calculations for ESSIV handling, use a > > > ESSIV skcipher which does all of this under the hood. > > > > > > Signed-off-by: Ard Biesheuvel > > > > This looks fine (except for one comment below), but this heavily conflicts with > > the fscrypt patches planned for v5.4. So I suggest moving this to the end of > > the series and having Herbert take only 1-6, and I'll apply this one to the > > fscrypt tree later. > > > > I think the same applies to dm-crypt: at least patch #7 cannot be > applied until my eboiv patch is applied there as well, but [Milan > should confirm] I'd expect them to prefer taking those patches via the > dm tree anyway. > > Herbert, what would you prefer: > - taking a pull request from a [signed] tag based on v4.3-rc1 that > contains patches #1, #4, #5 and #6, allowing Eric and Milan/Mike to > merge it as well, and apply the respective fscrypt and dm-crypt > changes on top > - just take patches #1, #4, #5 and #6 as usual, and let the fscrypt > and dm-crypt changes be reposted to the respective lists during the > next cycle > FWIW I'd much prefer the second option, to minimize the number of special things that Linus will have to consider or deal with. (There's also going to be a conflict between the fscrypt and keyrings trees.) I'd be glad to take the fscrypt patch for 5.5, if the essiv template is added in 5.4. - Eric