From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29D27C433FF for ; Thu, 15 Aug 2019 12:07:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 031CF20665 for ; Thu, 15 Aug 2019 12:07:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730300AbfHOMHx (ORCPT ); Thu, 15 Aug 2019 08:07:53 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:57250 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730087AbfHOMHx (ORCPT ); Thu, 15 Aug 2019 08:07:53 -0400 Received: from gondolin.me.apana.org.au ([192.168.0.6] helo=gondolin.hengli.com.au) by fornost.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1hyEXk-0003QB-P7; Thu, 15 Aug 2019 22:07:48 +1000 Received: from herbert by gondolin.hengli.com.au with local (Exim 4.80) (envelope-from ) id 1hyEXk-0007jc-B1; Thu, 15 Aug 2019 22:07:48 +1000 Date: Thu, 15 Aug 2019 22:07:48 +1000 From: Herbert Xu To: Pascal van Leeuwen Cc: linux-crypto@vger.kernel.org, davem@davemloft.net, Pascal van Leeuwen Subject: Re: [PATCH] crypto: aead - Do not allow authsize=0 if auth. alg has digestsize>0 Message-ID: <20190815120748.GH29355@gondor.apana.org.au> References: <1565365867-8251-1-git-send-email-pvanleeuwen@verimatrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1565365867-8251-1-git-send-email-pvanleeuwen@verimatrix.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Aug 09, 2019 at 05:51:07PM +0200, Pascal van Leeuwen wrote: > Return -EINVAL on an attempt to set the authsize to 0 with an auth. > algorithm with a non-zero digestsize (i.e. anything but digest_null) > as authenticating the data and then throwing away the result does not > make any sense at all. > > The digestsize zero exception is for use with digest_null for testing > purposes only. > > Signed-off-by: Pascal van Leeuwen > --- > crypto/aead.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt