From: Herbert Xu <herbert@gondor.apana.org.au>
To: Daniel Jordan <daniel.m.jordan@oracle.com>
Cc: Steffen Klassert <steffen.klassert@secunet.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] padata: validate cpumask without removed CPU during offline
Date: Thu, 22 Aug 2019 13:50:05 +1000 [thread overview]
Message-ID: <20190822035005.GA32551@gondor.apana.org.au> (raw)
In-Reply-To: <20190809210603.20900-1-daniel.m.jordan@oracle.com>
On Fri, Aug 09, 2019 at 05:06:03PM -0400, Daniel Jordan wrote:
>
> diff --git a/kernel/padata.c b/kernel/padata.c
> index d056276a96ce..01460ea1d160 100644
> --- a/kernel/padata.c
> +++ b/kernel/padata.c
> @@ -702,10 +702,7 @@ static int __padata_remove_cpu(struct padata_instance *pinst, int cpu)
> struct parallel_data *pd = NULL;
>
> if (cpumask_test_cpu(cpu, cpu_online_mask)) {
> -
> - if (!padata_validate_cpumask(pinst, pinst->cpumask.pcpu) ||
> - !padata_validate_cpumask(pinst, pinst->cpumask.cbcpu))
> - __padata_stop(pinst);
> + __padata_stop(pinst);
>
> pd = padata_alloc_pd(pinst, pinst->cpumask.pcpu,
> pinst->cpumask.cbcpu);
> @@ -716,6 +713,9 @@ static int __padata_remove_cpu(struct padata_instance *pinst, int cpu)
>
> cpumask_clear_cpu(cpu, pd->cpumask.cbcpu);
> cpumask_clear_cpu(cpu, pd->cpumask.pcpu);
> + if (padata_validate_cpumask(pinst, pd->cpumask.pcpu) &&
> + padata_validate_cpumask(pinst, pd->cpumask.cbcpu))
> + __padata_start(pinst);
> }
I looked back at the original code and in fact the original
assumption is to call this after cpu_online_mask has been modified.
So I suspect we need to change the state at which this is called
by CPU hotplug. IOW the commit that broke this is 30e92153b4e6.
This would also allow us to get rid of the two cpumask_clear_cpu
calls on pd->cpumask which is just bogus as you should only ever
modify the pd->cpumask prior to the padata_repalce call (because
the readers are not serialised with respect to this).
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2019-08-22 3:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 19:28 [PATCH 1/2] padata: always acquire cpu_hotplug_lock before pinst->lock Daniel Jordan
2019-08-09 19:28 ` [PATCH 2/2] padata: validate cpumask without removed CPU during offline Daniel Jordan
2019-08-09 21:06 ` [PATCH v2] " Daniel Jordan
2019-08-12 21:02 ` [PATCH 3/2] padata: initialize usable masks to reflect offlined CPU Daniel Jordan
2019-08-22 3:51 ` Herbert Xu
2019-08-22 22:11 ` Daniel Jordan
2019-08-22 3:50 ` Herbert Xu [this message]
2019-08-22 22:10 ` [PATCH v2] padata: validate cpumask without removed CPU during offline Daniel Jordan
2019-08-22 22:53 ` Daniel Jordan
2019-08-15 5:15 ` [PATCH 1/2] padata: always acquire cpu_hotplug_lock before pinst->lock Herbert Xu
2019-08-21 4:14 ` Daniel Jordan
2019-08-21 6:43 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190822035005.GA32551@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=daniel.m.jordan@oracle.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).