From: Herbert Xu <herbert@gondor.apana.org.au>
To: Pascal van Leeuwen <pascalvanl@gmail.com>
Cc: linux-crypto@vger.kernel.org, antoine.tenart@bootlin.com,
davem@davemloft.net,
Pascal van Leeuwen <pvanleeuwen@verimatrix.com>
Subject: Re: [PATCH] crypto: inside-secure - Fix unused variable warning when CONFIG_PCI=n
Date: Thu, 5 Sep 2019 23:03:37 +1000 [thread overview]
Message-ID: <20190905130337.GA31119@gondor.apana.org.au> (raw)
In-Reply-To: <1567663273-6652-1-git-send-email-pvanleeuwen@verimatrix.com>
On Thu, Sep 05, 2019 at 08:01:13AM +0200, Pascal van Leeuwen wrote:
> This patch fixes an unused variable warning from the compiler when the
> driver is being compiled without PCI support in the kernel.
>
> Signed-off-by: Pascal van Leeuwen <pvanleeuwen@verimatrix.com>
> ---
> drivers/crypto/inside-secure/safexcel.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure/safexcel.c
> index e12a2a3..0f1a9dc 100644
> --- a/drivers/crypto/inside-secure/safexcel.c
> +++ b/drivers/crypto/inside-secure/safexcel.c
> @@ -1503,7 +1503,9 @@ void safexcel_pci_remove(struct pci_dev *pdev)
>
> static int __init safexcel_init(void)
> {
> +#if IS_ENABLED(CONFIG_PCI)
> int rc;
> +#endif
>
> #if IS_ENABLED(CONFIG_OF)
> /* Register platform driver */
Shouldn't you check for errors for CONFIG_OF too?
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2019-09-05 13:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 6:01 [PATCH] crypto: inside-secure - Fix unused variable warning when CONFIG_PCI=n Pascal van Leeuwen
2019-09-05 13:03 ` Herbert Xu [this message]
2019-09-05 13:55 ` Pascal Van Leeuwen
2019-09-05 13:59 ` Herbert Xu
2019-09-05 14:07 ` Pascal Van Leeuwen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190905130337.GA31119@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=linux-crypto@vger.kernel.org \
--cc=pascalvanl@gmail.com \
--cc=pvanleeuwen@verimatrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).