From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AB81C00307 for ; Mon, 9 Sep 2019 07:23:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7174921920 for ; Mon, 9 Sep 2019 07:23:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731974AbfIIHW5 (ORCPT ); Mon, 9 Sep 2019 03:22:57 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:32838 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728298AbfIIHW5 (ORCPT ); Mon, 9 Sep 2019 03:22:57 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.89 #2 (Debian)) id 1i7E0e-0007BW-5B; Mon, 09 Sep 2019 17:22:49 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Mon, 09 Sep 2019 17:22:47 +1000 Date: Mon, 9 Sep 2019 17:22:47 +1000 From: Herbert Xu To: Horia Geanta Cc: Andrey Smirnov , "linux-crypto@vger.kernel.org" , Chris Healy , Lucas Stach , Iuliana Prodan , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 01/12] crypto: caam - make sure clocks are enabled first Message-ID: <20190909072247.GA18908@gondor.apana.org.au> References: <20190904023515.7107-1-andrew.smirnov@gmail.com> <20190904023515.7107-2-andrew.smirnov@gmail.com> <20190909072155.GA18825@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190909072155.GA18825@gondor.apana.org.au> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, Sep 09, 2019 at 05:21:55PM +1000, Herbert Xu wrote: > On Fri, Sep 06, 2019 at 11:18:19AM +0000, Horia Geanta wrote: > > On 9/4/2019 5:35 AM, Andrey Smirnov wrote: > > > In order to access IP block's registers we need to enable appropriate > > > clocks first, otherwise we are risking hanging the CPU. > > > > > > The problem becomes very apparent when trying to use CAAM driver built > > > as a kernel module. In that case caam_probe() gets called after > > > clk_disable_unused() which means all of the necessary clocks are > > > guaranteed to be disabled. > > > > > > Coincidentally, this change also fixes iomap leak introduced by early > > > return (instead of "goto iounmap_ctrl") in commit > > > 41fc54afae70 ("crypto: caam - simplfy clock initialization") > > > > > > Tested on ZII i.MX6Q+ RDU2 > > > > > > Fixes: 176435ad2ac7 ("crypto: caam - defer probing until QMan is available") > > > Fixes: 41fc54afae70 ("crypto: caam - simplfy clock initialization") > > > Signed-off-by: Andrey Smirnov > > > Cc: Chris Healy > > > Cc: Lucas Stach > > > Cc: Horia Geantă > > > Cc: Herbert Xu > > > Cc: Iuliana Prodan > > > Cc: linux-crypto@vger.kernel.org > > > Cc: linux-kernel@vger.kernel.org > > Tested-by: Horia Geantă > > > > Considering this is a boot hang, in case this does not make into v5.4 > > I would appreciate appending: > > Cc: > > This patch does not apply against cryptodev or crypto. Nevermind, I was trying to apply patch 4 on top of patch 1 which is why it didn't work. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt