From: Herbert Xu <herbert@gondor.apana.org.au>
To: Stephen Boyd <swboyd@chromium.org>
Cc: linux-kernel@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>,
linux-crypto@vger.kernel.org,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Keerthy <j-keerthy@ti.com>
Subject: Re: [PATCH] random: Use wait_event_freezable() in add_hwgenerator_randomness()
Date: Mon, 9 Sep 2019 17:54:20 +1000 [thread overview]
Message-ID: <20190909075420.GG21364@gondor.apana.org.au> (raw)
In-Reply-To: <20190905164112.245886-1-swboyd@chromium.org>
On Thu, Sep 05, 2019 at 09:41:12AM -0700, Stephen Boyd wrote:
> Sebastian reports that after commit ff296293b353 ("random: Support freezable
> kthreads in add_hwgenerator_randomness()") we can call might_sleep() when the
> task state is TASK_INTERRUPTIBLE (state=1). This leads to the following warning.
>
> do not call blocking ops when !TASK_RUNNING; state=1 set at [<00000000349d1489>] prepare_to_wait_event+0x5a/0x180
> WARNING: CPU: 0 PID: 828 at kernel/sched/core.c:6741 __might_sleep+0x6f/0x80
> Modules linked in:
>
> CPU: 0 PID: 828 Comm: hwrng Not tainted 5.3.0-rc7-next-20190903+ #46
> RIP: 0010:__might_sleep+0x6f/0x80
>
> Call Trace:
> kthread_freezable_should_stop+0x1b/0x60
> add_hwgenerator_randomness+0xdd/0x130
> hwrng_fillfn+0xbf/0x120
> kthread+0x10c/0x140
> ret_from_fork+0x27/0x50
>
> We shouldn't call kthread_freezable_should_stop() from deep within the
> wait_event code because the task state is still set as
> TASK_INTERRUPTIBLE instead of TASK_RUNNING and
> kthread_freezable_should_stop() will try to call into the freezer with
> the task in the wrong state. Use wait_event_freezable() instead so that
> it calls schedule() in the right place and tries to enter the freezer
> when the task state is TASK_RUNNING instead.
>
> Reported-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Tested-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Cc: Keerthy <j-keerthy@ti.com>
> Fixes: ff296293b353 ("random: Support freezable kthreads in add_hwgenerator_randomness()")
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
>
> See https://lkml.kernel.org/r/20190904110038.2bx25byitrejlteu@flow for
> context on the bug report.
>
> drivers/char/random.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2019-09-09 7:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 16:41 [PATCH] random: Use wait_event_freezable() in add_hwgenerator_randomness() Stephen Boyd
2019-09-09 7:54 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190909075420.GG21364@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=bigeasy@linutronix.de \
--cc=j-keerthy@ti.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swboyd@chromium.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).