Linux-Crypto Archive on lore.kernel.org
 help / color / Atom feed
From: Sebastian Reichel <sre@kernel.org>
To: Tony Lindgren <tony@atomide.com>
Cc: "Matt Mackall" <mpm@selenic.com>,
	"Herbert Xu" <herbert@gondor.apana.org.au>,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-crypto@vger.kernel.org,
	"Aaro Koskinen" <aaro.koskinen@iki.fi>,
	"Adam Ford" <aford173@gmail.com>,
	"Pali Rohár" <pali.rohar@gmail.com>,
	"Tero Kristo" <t-kristo@ti.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 3/6] hwrng: omap3-rom - Call clk_prepare() on init and exit only
Date: Sat, 14 Sep 2019 14:54:27 +0200
Message-ID: <20190914125427.nvbrxoubvll43b3j@earth.universe> (raw)
In-Reply-To: <20190913220922.29501-4-tony@atomide.com>

[-- Attachment #1: Type: text/plain, Size: 373 bytes --]

Hi,

On Fri, Sep 13, 2019 at 03:09:19PM -0700, Tony Lindgren wrote:
> Also, we should not call prepare and unprepare except during init, and
> only call enable and disable during use.

Why? Usually clk_(un)prepare() is the part saving most power, so I
would expect the runtime resume handlers to call clk_prepare_enable
and vice versa in the suspend handler.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply index

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-13 22:09 [PATCH 0/6] Non-urgent fixes and improvments for omap3-rom-rng Tony Lindgren
2019-09-13 22:09 ` [PATCH 1/6] ARM: OMAP2+: Check omap3-rom-rng for GP device instead of HS device Tony Lindgren
2019-09-13 22:09 ` [PATCH 2/6] hwrng: omap3-rom - Fix missing clock by probing with device tree Tony Lindgren
2019-09-13 22:09 ` [PATCH 3/6] hwrng: omap3-rom - Call clk_prepare() on init and exit only Tony Lindgren
2019-09-14 12:54   ` Sebastian Reichel [this message]
2019-09-14 17:57     ` Tony Lindgren
2019-09-13 22:09 ` [PATCH 4/6] hwrng: omap3-rom - Initialize default quality to get data Tony Lindgren
2019-09-13 22:09 ` [PATCH 5/6] hwrng: omap3-rom - Update to use standard driver data Tony Lindgren
2019-09-13 22:09 ` [PATCH 6/6] hwrng: omap3-rom - Use runtime PM instead of custom functions Tony Lindgren
2019-09-14 13:05 ` [PATCH 0/6] Non-urgent fixes and improvments for omap3-rom-rng Sebastian Reichel
2019-09-14 17:59   ` Tony Lindgren

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190914125427.nvbrxoubvll43b3j@earth.universe \
    --to=sre@kernel.org \
    --cc=aaro.koskinen@iki.fi \
    --cc=aford173@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mpm@selenic.com \
    --cc=pali.rohar@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=t-kristo@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Crypto Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-crypto/0 linux-crypto/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-crypto linux-crypto/ https://lore.kernel.org/linux-crypto \
		linux-crypto@vger.kernel.org linux-crypto@archiver.kernel.org
	public-inbox-index linux-crypto

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-crypto


AGPL code for this site: git clone https://public-inbox.org/ public-inbox