* [PATCH] crypto: talitos - fix missing break in switch statement
@ 2019-09-09 5:29 Gustavo A. R. Silva
2019-09-10 6:06 ` Christophe Leroy
2019-09-20 12:59 ` Herbert Xu
0 siblings, 2 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2019-09-09 5:29 UTC (permalink / raw)
To: Herbert Xu, David S. Miller
Cc: linux-crypto, linux-kernel, Gustavo A. R. Silva
Add missing break statement in order to prevent the code from falling
through to case CRYPTO_ALG_TYPE_AHASH.
Fixes: aeb4c132f33d ("crypto: talitos - Convert to new AEAD interface")
Cc: stable@vger.kernel.org
Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/crypto/talitos.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c
index c9d686a0e805..4818ae427098 100644
--- a/drivers/crypto/talitos.c
+++ b/drivers/crypto/talitos.c
@@ -3140,6 +3140,7 @@ static int talitos_remove(struct platform_device *ofdev)
break;
case CRYPTO_ALG_TYPE_AEAD:
crypto_unregister_aead(&t_alg->algt.alg.aead);
+ break;
case CRYPTO_ALG_TYPE_AHASH:
crypto_unregister_ahash(&t_alg->algt.alg.hash);
break;
--
2.23.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: talitos - fix missing break in switch statement
2019-09-09 5:29 [PATCH] crypto: talitos - fix missing break in switch statement Gustavo A. R. Silva
@ 2019-09-10 6:06 ` Christophe Leroy
2019-09-20 14:53 ` Gustavo A. R. Silva
2019-09-20 12:59 ` Herbert Xu
1 sibling, 1 reply; 4+ messages in thread
From: Christophe Leroy @ 2019-09-10 6:06 UTC (permalink / raw)
To: Gustavo A. R. Silva, Herbert Xu, David S. Miller
Cc: linux-crypto, linux-kernel
Le 09/09/2019 à 07:29, Gustavo A. R. Silva a écrit :
> Add missing break statement in order to prevent the code from falling
> through to case CRYPTO_ALG_TYPE_AHASH.
>
> Fixes: aeb4c132f33d ("crypto: talitos - Convert to new AEAD interface")
> Cc: stable@vger.kernel.org
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>
> ---
> drivers/crypto/talitos.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c
> index c9d686a0e805..4818ae427098 100644
> --- a/drivers/crypto/talitos.c
> +++ b/drivers/crypto/talitos.c
> @@ -3140,6 +3140,7 @@ static int talitos_remove(struct platform_device *ofdev)
> break;
> case CRYPTO_ALG_TYPE_AEAD:
> crypto_unregister_aead(&t_alg->algt.alg.aead);
> + break;
> case CRYPTO_ALG_TYPE_AHASH:
> crypto_unregister_ahash(&t_alg->algt.alg.hash);
> break;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: talitos - fix missing break in switch statement
2019-09-09 5:29 [PATCH] crypto: talitos - fix missing break in switch statement Gustavo A. R. Silva
2019-09-10 6:06 ` Christophe Leroy
@ 2019-09-20 12:59 ` Herbert Xu
1 sibling, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2019-09-20 12:59 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: David S. Miller, linux-crypto, linux-kernel
On Mon, Sep 09, 2019 at 12:29:52AM -0500, Gustavo A. R. Silva wrote:
> Add missing break statement in order to prevent the code from falling
> through to case CRYPTO_ALG_TYPE_AHASH.
>
> Fixes: aeb4c132f33d ("crypto: talitos - Convert to new AEAD interface")
> Cc: stable@vger.kernel.org
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/crypto/talitos.c | 1 +
> 1 file changed, 1 insertion(+)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: talitos - fix missing break in switch statement
2019-09-10 6:06 ` Christophe Leroy
@ 2019-09-20 14:53 ` Gustavo A. R. Silva
0 siblings, 0 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2019-09-20 14:53 UTC (permalink / raw)
To: Christophe Leroy, Herbert Xu, David S. Miller; +Cc: linux-crypto, linux-kernel
Hi all,
Friendly ping:
Who can take this?
Thanks
--
Gustavo
On 9/10/19 01:06, Christophe Leroy wrote:
>
>
> Le 09/09/2019 à 07:29, Gustavo A. R. Silva a écrit :
>> Add missing break statement in order to prevent the code from falling
>> through to case CRYPTO_ALG_TYPE_AHASH.
>>
>> Fixes: aeb4c132f33d ("crypto: talitos - Convert to new AEAD interface")
>> Cc: stable@vger.kernel.org
>> Reported-by: kbuild test robot <lkp@intel.com>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>
>
>> ---
>> drivers/crypto/talitos.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c
>> index c9d686a0e805..4818ae427098 100644
>> --- a/drivers/crypto/talitos.c
>> +++ b/drivers/crypto/talitos.c
>> @@ -3140,6 +3140,7 @@ static int talitos_remove(struct platform_device *ofdev)
>> break;
>> case CRYPTO_ALG_TYPE_AEAD:
>> crypto_unregister_aead(&t_alg->algt.alg.aead);
>> + break;
>> case CRYPTO_ALG_TYPE_AHASH:
>> crypto_unregister_ahash(&t_alg->algt.alg.hash);
>> break;
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-20 13:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-09 5:29 [PATCH] crypto: talitos - fix missing break in switch statement Gustavo A. R. Silva
2019-09-10 6:06 ` Christophe Leroy
2019-09-20 14:53 ` Gustavo A. R. Silva
2019-09-20 12:59 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).