From: Herbert Xu <herbert@gondor.apana.org.au>
To: Ard Biesheuvel <ard.biesheuvel@arm.com>
Cc: linux-crypto@vger.kernel.org, Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH 1/2] crypto: arm/aes-ce - build for v8 architecture explicitly
Date: Tue, 1 Oct 2019 23:07:53 +1000 [thread overview]
Message-ID: <20191001130753.GA3434@gondor.apana.org.au> (raw)
In-Reply-To: <20190917085001.792-1-ard.biesheuvel@arm.com>
On Tue, Sep 17, 2019 at 09:50:00AM +0100, Ard Biesheuvel wrote:
> From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> The NEON/Crypto Extensions based AES implementation for 32-bit ARM
> can be built in a kernel that targets ARMv6 CPUs and higher, even
> though the actual code will not be able to run on that generation,
> but it allows for a portable image to be generated that can will
> use the special instructions only when they are available.
>
> Since those instructions are part of a FPU profile rather than a
> CPU profile, we don't override the architecture in the assembler
> code, and most of the scalar code is simple enough to be ARMv6
> compatible. However, that changes with commit c61b1607ed4fbbf2,
> which introduces calls to the movw/movt instructions, which are
> v7+ only.
>
> So override the architecture in the .S file to armv8-a, which
> matches the architecture specification in the crypto-neon-fp-armv8
> FPU specificier that we already using. Note that using armv7-a
> here may trigger an issue with the upcoming Clang 10 release,
> which no longer permits .arch/.fpu combinations it views as
> incompatible.
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Fixes: c61b1607ed4fbbf2("crypto: arm/aes-ce - implement ciphertext stealing ...")
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> arch/arm/crypto/aes-ce-core.S | 1 +
> 1 file changed, 1 insertion(+)
All applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2019-10-01 13:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 8:50 [PATCH 1/2] crypto: arm/aes-ce - build for v8 architecture explicitly Ard Biesheuvel
2019-09-17 8:50 ` [PATCH 2/2] crypto: arm/aes-ce - add dependency on AES library Ard Biesheuvel
2019-10-01 13:07 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001130753.GA3434@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ard.biesheuvel@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).