linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Maxime Ripard <mripard@kernel.org>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: catalin.marinas@arm.com, davem@davemloft.net,
	herbert@gondor.apana.org.au, linux@armlinux.org.uk,
	mark.rutland@arm.com, robh+dt@kernel.org, wens@csie.org,
	will@kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-sunxi@googlegroups.com
Subject: Re: [PATCH v2 05/11] ARM: dts: sun8i: H3: Add Crypto Engine node
Date: Wed, 2 Oct 2019 08:02:14 +0200	[thread overview]
Message-ID: <20191002060214.bu67nkd3y6puknrb@gilmour> (raw)
In-Reply-To: <20191001184141.27956-6-clabbe.montjoie@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1174 bytes --]

On Tue, Oct 01, 2019 at 08:41:35PM +0200, Corentin Labbe wrote:
> The Crypto Engine is a hardware cryptographic accelerator that supports
> many algorithms.
> It could be found on most Allwinner SoCs.
>
> This patch enables the Crypto Engine on the Allwinner H3 SoC Device-tree.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> ---
>  arch/arm/boot/dts/sun8i-h3.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
> index e37c30e811d3..778a23a794c9 100644
> --- a/arch/arm/boot/dts/sun8i-h3.dtsi
> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi
> @@ -153,6 +153,17 @@
>  			allwinner,sram = <&ve_sram 1>;
>  		};
>
> +		crypto: crypto@1c15000 {
> +			compatible = "allwinner,sun8i-h3-crypto";
> +			reg = <0x01c15000 0x1000>;
> +			interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>;
> +			interrupt-names = "ce_ns";

That's not documented in the binding (and I guess unnecessary)

> +			resets = <&ccu RST_BUS_CE>;
> +			reset-names = "bus";
> +			clocks = <&ccu CLK_BUS_CE>, <&ccu CLK_CE>;
> +			clock-names = "bus", "mod";

Nit: we put the clocks before the resets usually

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2019-10-02  6:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-01 18:41 [PATCH v2 00/11] crypto: add sun8i-ce driver for Allwinner crypto engine Corentin Labbe
2019-10-01 18:41 ` [PATCH v2 01/11] crypto: Add allwinner subdirectory Corentin Labbe
2019-10-01 18:41 ` [PATCH v2 02/11] crypto: Add Allwinner sun8i-ce Crypto Engine Corentin Labbe
2019-10-02 10:35   ` Maxime Ripard
2019-10-04 17:52     ` Corentin Labbe
2019-10-01 18:41 ` [PATCH v2 03/11] dt-bindings: crypto: Add DT bindings documentation for " Corentin Labbe
2019-10-02  5:54   ` Maxime Ripard
2019-10-04 17:53     ` Corentin Labbe
2019-10-01 18:41 ` [PATCH v2 04/11] ARM: dts: sun8i: R40: add crypto engine node Corentin Labbe
2019-10-02  8:08   ` [linux-sunxi] " Priit Laes
2019-10-02  8:44     ` Corentin Labbe
2019-10-01 18:41 ` [PATCH v2 05/11] ARM: dts: sun8i: H3: Add Crypto Engine node Corentin Labbe
2019-10-02  6:02   ` Maxime Ripard [this message]
2019-10-02  8:44     ` Corentin Labbe
2019-10-01 18:41 ` [PATCH v2 06/11] ARM64: dts: allwinner: sun50i: Add Crypto Engine node on A64 Corentin Labbe
2019-10-01 18:41 ` [PATCH v2 07/11] ARM64: dts: allwinner: sun50i: Add crypto engine node on H5 Corentin Labbe
2019-10-01 18:41 ` [PATCH v2 08/11] ARM64: dts: allwinner: sun50i: Add Crypto Engine node on H6 Corentin Labbe
2019-10-01 18:41 ` [PATCH v2 09/11] sunxi_defconfig: add new Allwinner crypto options Corentin Labbe
2019-10-01 18:41 ` [PATCH v2 10/11] arm64: defconfig: " Corentin Labbe
2019-10-01 18:41 ` [PATCH v2 11/11] crypto: sun4i-ss: Move to Allwinner directory Corentin Labbe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191002060214.bu67nkd3y6puknrb@gilmour \
    --to=mripard@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=clabbe.montjoie@gmail.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=wens@csie.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).