* [PATCH] crypto: user - fix memory leak in crypto_reportstat
@ 2019-10-04 19:34 Navid Emamdoost
2019-10-05 15:27 ` Markus Elfring
2019-10-10 12:58 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Navid Emamdoost @ 2019-10-04 19:34 UTC (permalink / raw)
Cc: emamd001, kjlu, smccaman, Navid Emamdoost, Herbert Xu,
David S. Miller, linux-crypto, linux-kernel
In crypto_reportstat, a new skb is created by nlmsg_new(). This skb is
leaked if crypto_reportstat_alg() fails. Required release for skb is
added.
Fixes: cac5818c25d0 ("crypto: user - Implement a generic crypto statistics")
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
---
crypto/crypto_user_stat.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/crypto/crypto_user_stat.c b/crypto/crypto_user_stat.c
index 8bad88413de1..1be95432fa23 100644
--- a/crypto/crypto_user_stat.c
+++ b/crypto/crypto_user_stat.c
@@ -328,8 +328,10 @@ int crypto_reportstat(struct sk_buff *in_skb, struct nlmsghdr *in_nlh,
drop_alg:
crypto_mod_put(alg);
- if (err)
+ if (err) {
+ kfree_skb(skb);
return err;
+ }
return nlmsg_unicast(net->crypto_nlsk, skb, NETLINK_CB(in_skb).portid);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: user - fix memory leak in crypto_reportstat
2019-10-04 19:34 [PATCH] crypto: user - fix memory leak in crypto_reportstat Navid Emamdoost
@ 2019-10-05 15:27 ` Markus Elfring
2019-10-10 12:58 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2019-10-05 15:27 UTC (permalink / raw)
To: Navid Emamdoost, linux-crypto
Cc: Navid Emamdoost, Kangjie Lu, Stephen McCamant, David S. Miller,
Herbert Xu, linux-kernel, kernel-janitors
> In crypto_reportstat, a new skb is created by nlmsg_new(). This skb is
> leaked if crypto_reportstat_alg() fails. Required release for skb is
> added.
Please improve this change description.
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: user - fix memory leak in crypto_reportstat
2019-10-04 19:34 [PATCH] crypto: user - fix memory leak in crypto_reportstat Navid Emamdoost
2019-10-05 15:27 ` Markus Elfring
@ 2019-10-10 12:58 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2019-10-10 12:58 UTC (permalink / raw)
To: Navid Emamdoost
Cc: emamd001, kjlu, smccaman, David S. Miller, linux-crypto, linux-kernel
On Fri, Oct 04, 2019 at 02:34:54PM -0500, Navid Emamdoost wrote:
> In crypto_reportstat, a new skb is created by nlmsg_new(). This skb is
> leaked if crypto_reportstat_alg() fails. Required release for skb is
> added.
>
> Fixes: cac5818c25d0 ("crypto: user - Implement a generic crypto statistics")
> Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
> ---
> crypto/crypto_user_stat.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-10 12:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-04 19:34 [PATCH] crypto: user - fix memory leak in crypto_reportstat Navid Emamdoost
2019-10-05 15:27 ` Markus Elfring
2019-10-10 12:58 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).