Linux-Crypto Archive on
 help / color / Atom feed
From: Eric Biggers <>
To: Christoph Hellwig <>
Cc: Herbert Xu <>,,,
	"David S . Miller" <>
Subject: Re: [RFT PATCH 0/3] crypto: sparc - convert to skcipher API
Date: Tue, 15 Oct 2019 09:25:39 -0700
Message-ID: <20191015162539.GA852@sol.localdomain> (raw)
In-Reply-To: <>

On Tue, Oct 15, 2019 at 01:11:38AM -0700, Christoph Hellwig wrote:
> On Fri, Oct 11, 2019 at 09:38:47PM -0700, Eric Biggers wrote:
> > This series converts the glue code for the SPARC64 crypto opcodes
> > implementations of AES, Camellia, DES, and 3DES modes from the
> > deprecated "blkcipher" API to the "skcipher" API.  This is needed in
> > order for the blkcipher API to be removed.
> Not knowing much about the API: do you have an explanation of what the
> difference is and why it matters?

They're all APIs for length-preserving encryption algorithms, but the skcipher
API has some improvements, such as:

    - a much less confusing name
    - better type safety (skcipher_alg, crypto_skcipher, etc. instead of
      crypto_alg, crypto_tfm, etc.)
    - optional support for asynchronous operation (like "ablkcipher")
    - optional support per request-contexts (like "ablkcipher")
    - simpler scatterlist walks for some algorithms

The skcipher API was introduced in 2015 to replace blkcipher and ablkcipher, and
most implementations and almost all API users were converted.  But some
implementations weren't converted, so the crypto subsystem still has to carry
all the blkcipher and ablkcipher compatibility code, as well as all
documentation for blkcipher and ablkcipher.  This is really confusing for people
working with the crypto API, and bad for testing as there's no easy way to test
{,a}blkcipher on x86, arm, or arm64 anymore.  So, Ard and I are finishing the
conversions so that blkcipher and ablkcipher can finally be removed.

- Eric

  reply index

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-12  4:38 Eric Biggers
2019-10-12  4:38 ` [RFT PATCH 1/3] crypto: sparc/aes " Eric Biggers
2019-10-12  4:38 ` [RFT PATCH 2/3] crypto: sparc/camellia " Eric Biggers
2019-10-12  4:38 ` [RFT PATCH 3/3] crypto: sparc/des " Eric Biggers
2019-10-12  5:12 ` [RFT PATCH 0/3] crypto: sparc " David Miller
     [not found] ` <>
2019-10-12  5:25   ` Eric Biggers
2019-10-15  8:11 ` Christoph Hellwig
2019-10-15 16:25   ` Eric Biggers [this message]
2019-10-18  7:17 ` Anatoly Pugachev
2019-10-18  8:05 ` Herbert Xu

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191015162539.GA852@sol.localdomain \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Crypto Archive on

Archives are clonable:
	git clone --mirror linux-crypto/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-crypto linux-crypto/ \
	public-inbox-index linux-crypto

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone