From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF165C10F14 for ; Tue, 15 Oct 2019 16:25:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A752520872 for ; Tue, 15 Oct 2019 16:25:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571156742; bh=9JG55cwvKySt54+bjBUW5hdtYN86mrw1dcSP1VGesMk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Poj95HTyLHVCF51uyYVeU6lOlkito1lDv//0CdOYw+PFw6ATa9PUxX0OAFVmxe4FC Q17Y4DRqqWeXgWNslbRy7aKP4DNjeTBixrWPrS0w7IrQXKPHmdQ3kAnJj8in4kvf6U PJ9HSysYmafTGZX+fWG8GopVuMK6zWyqAEAjJ258= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726200AbfJOQZm (ORCPT ); Tue, 15 Oct 2019 12:25:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:47128 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725804AbfJOQZl (ORCPT ); Tue, 15 Oct 2019 12:25:41 -0400 Received: from sol.localdomain (c-24-5-143-220.hsd1.ca.comcast.net [24.5.143.220]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E203E2086A; Tue, 15 Oct 2019 16:25:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571156741; bh=9JG55cwvKySt54+bjBUW5hdtYN86mrw1dcSP1VGesMk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Pxn30roB0HoZF4bdmmOtOx+jCJsmf6mLH+Gk/jvQU71OtO9uII3GS6w0tgi2Oh5QR Y15ac4YQo6HjJDy8aT1vjUAc4neG3AyvDWZfIvI8kOyfb1kb4oxxTBJD7s3aMVyL3d CkFaaybuvECb/3mKLcHnM+cyEg6ewAOWTu4ol3Yk= Date: Tue, 15 Oct 2019 09:25:39 -0700 From: Eric Biggers To: Christoph Hellwig Cc: Herbert Xu , linux-crypto@vger.kernel.org, sparclinux@vger.kernel.org, "David S . Miller" Subject: Re: [RFT PATCH 0/3] crypto: sparc - convert to skcipher API Message-ID: <20191015162539.GA852@sol.localdomain> Mail-Followup-To: Christoph Hellwig , Herbert Xu , linux-crypto@vger.kernel.org, sparclinux@vger.kernel.org, "David S . Miller" References: <20191012043850.340957-1-ebiggers@kernel.org> <20191015081138.GA23837@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191015081138.GA23837@infradead.org> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Oct 15, 2019 at 01:11:38AM -0700, Christoph Hellwig wrote: > On Fri, Oct 11, 2019 at 09:38:47PM -0700, Eric Biggers wrote: > > This series converts the glue code for the SPARC64 crypto opcodes > > implementations of AES, Camellia, DES, and 3DES modes from the > > deprecated "blkcipher" API to the "skcipher" API. This is needed in > > order for the blkcipher API to be removed. > > Not knowing much about the API: do you have an explanation of what the > difference is and why it matters? > They're all APIs for length-preserving encryption algorithms, but the skcipher API has some improvements, such as: - a much less confusing name - better type safety (skcipher_alg, crypto_skcipher, etc. instead of crypto_alg, crypto_tfm, etc.) - optional support for asynchronous operation (like "ablkcipher") - optional support per request-contexts (like "ablkcipher") - simpler scatterlist walks for some algorithms The skcipher API was introduced in 2015 to replace blkcipher and ablkcipher, and most implementations and almost all API users were converted. But some implementations weren't converted, so the crypto subsystem still has to carry all the blkcipher and ablkcipher compatibility code, as well as all documentation for blkcipher and ablkcipher. This is really confusing for people working with the crypto API, and bad for testing as there's no easy way to test {,a}blkcipher on x86, arm, or arm64 anymore. So, Ard and I are finishing the conversions so that blkcipher and ablkcipher can finally be removed. - Eric