From: Herbert Xu <herbert@gondor.apana.org.au>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net, linux-kernel@lists.codethink.co.uk
Subject: Re: [PATCH] crypto: jitter - add header to fix buildwarnings
Date: Fri, 18 Oct 2019 19:02:25 +1100 [thread overview]
Message-ID: <20191018080225.GB25128@gondor.apana.org.au> (raw)
In-Reply-To: <20191009091256.12896-1-ben.dooks@codethink.co.uk>
On Wed, Oct 09, 2019 at 10:12:56AM +0100, Ben Dooks wrote:
> Fix the following build warnings by adding a header for
> the definitions shared between jitterentropy.c and
> jitterentropy-kcapi.c. Fixes the following:
>
> crypto/jitterentropy.c:445:5: warning: symbol 'jent_read_entropy' was not declared. Should it be static?
> crypto/jitterentropy.c:475:18: warning: symbol 'jent_entropy_collector_alloc' was not declared. Should it be static?
> crypto/jitterentropy.c:509:6: warning: symbol 'jent_entropy_collector_free' was not declared. Should it be static?
> crypto/jitterentropy.c:516:5: warning: symbol 'jent_entropy_init' was not declared. Should it be static?
> crypto/jitterentropy-kcapi.c:59:6: warning: symbol 'jent_zalloc' was not declared. Should it be static?
> crypto/jitterentropy-kcapi.c:64:6: warning: symbol 'jent_zfree' was not declared. Should it be static?
> crypto/jitterentropy-kcapi.c:69:5: warning: symbol 'jent_fips_enabled' was not declared. Should it be static?
> crypto/jitterentropy-kcapi.c:74:6: warning: symbol 'jent_panic' was not declared. Should it be static?
> crypto/jitterentropy-kcapi.c:79:6: warning: symbol 'jent_memcpy' was not declared. Should it be static?
> crypto/jitterentropy-kcapi.c:93:6: warning: symbol 'jent_get_nstime' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> crypto/jitterentropy-kcapi.c | 8 +-------
> crypto/jitterentropy.c | 7 +------
> crypto/jitterentropy.h | 17 +++++++++++++++++
> 3 files changed, 19 insertions(+), 13 deletions(-)
> create mode 100644 crypto/jitterentropy.h
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2019-10-18 8:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 9:12 [PATCH] crypto: jitter - add header to fix buildwarnings Ben Dooks
2019-10-09 9:22 ` Stephan Mueller
2019-10-18 8:02 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018080225.GB25128@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ben.dooks@codethink.co.uk \
--cc=davem@davemloft.net \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).