From: Herbert Xu <herbert@gondor.apana.org.au>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, arnd@arndb.de
Subject: Re: [PATCH] crypto: arm - use Kconfig based compiler checks for crypto opcodes
Date: Fri, 18 Oct 2019 19:04:15 +1100 [thread overview]
Message-ID: <20191018080415.GF25128@gondor.apana.org.au> (raw)
In-Reply-To: <20191011090800.29386-1-ard.biesheuvel@linaro.org>
On Fri, Oct 11, 2019 at 11:08:00AM +0200, Ard Biesheuvel wrote:
> Instead of allowing the Crypto Extensions algorithms to be selected when
> using a toolchain that does not support them, and complain about it at
> build time, use the information we have about the compiler to prevent
> them from being selected in the first place. Users that are stuck with
> a GCC version <4.8 are unlikely to care about these routines anyway, and
> it cleans up the Makefile considerably.
>
> While at it, add explicit 'armv8-a' CPU specifiers to the code that uses
> the 'crypto-neon-fp-armv8' FPU specifier so we don't regress Clang, which
> will complain about this in version 10 and later.
>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> arch/arm/crypto/Kconfig | 14 +++++++------
> arch/arm/crypto/Makefile | 32 ++++++-----------------------
> arch/arm/crypto/aes-ce-core.S | 1 +
> arch/arm/crypto/crct10dif-ce-core.S | 2 +-
> arch/arm/crypto/ghash-ce-core.S | 1 +
> arch/arm/crypto/sha1-ce-core.S | 1 +
> arch/arm/crypto/sha2-ce-core.S | 1 +
> 7 files changed, 19 insertions(+), 33 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2019-10-18 8:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 9:08 [PATCH] crypto: arm - use Kconfig based compiler checks for crypto opcodes Ard Biesheuvel
2019-10-18 8:04 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018080415.GF25128@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).