From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC8F3CA9EA0 for ; Fri, 18 Oct 2019 08:05:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C299A21D80 for ; Fri, 18 Oct 2019 08:05:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728653AbfJRIFn (ORCPT ); Fri, 18 Oct 2019 04:05:43 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:37384 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727888AbfJRIFn (ORCPT ); Fri, 18 Oct 2019 04:05:43 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.89 #2 (Debian)) id 1iLNGT-0001yR-Uj; Fri, 18 Oct 2019 19:05:39 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 18 Oct 2019 19:05:37 +1100 Date: Fri, 18 Oct 2019 19:05:37 +1100 From: Herbert Xu To: Eric Biggers Cc: linux-crypto@vger.kernel.org, linux-s390@vger.kernel.org, Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Harald Freudenberger Subject: Re: [RFT PATCH 0/3] crypto: s390 - convert to skcipher API Message-ID: <20191018080537.GK25128@gondor.apana.org.au> References: <20191012201809.160500-1-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191012201809.160500-1-ebiggers@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sat, Oct 12, 2019 at 01:18:06PM -0700, Eric Biggers wrote: > This series converts the glue code for the S390 CPACF implementations of > AES, DES, and 3DES modes from the deprecated "blkcipher" API to the > "skcipher" API. This is needed in order for the blkcipher API to be > removed. > > I've compiled this patchset, and the conversion is very similar to that > which has been done for many other crypto drivers. But I don't have the > hardware to test it, nor is S390 CPACF supported by QEMU. So I really > need someone with the hardware to test it. You can do so by setting: > > CONFIG_CRYPTO_HW=y > CONFIG_ZCRYPT=y > CONFIG_PKEY=y > CONFIG_CRYPTO_AES_S390=y > CONFIG_CRYPTO_PAES_S390=y > CONFIG_CRYPTO_DES_S390=y > # CONFIG_CRYPTO_MANAGER_DISABLE_TESTS is not set > CONFIG_DEBUG_KERNEL=y > CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y > CONFIG_CRYPTO_AES=y > CONFIG_CRYPTO_DES=y > CONFIG_CRYPTO_CBC=y > CONFIG_CRYPTO_CTR=y > CONFIG_CRYPTO_ECB=y > CONFIG_CRYPTO_XTS=y > > Then boot and check for crypto self-test failures by running > 'dmesg | grep alg'. > > If there are test failures, please also check whether they were already > failing prior to this patchset. > > This won't cover the "paes" ("protected key AES") algorithms, however, > since those don't have self-tests. If anyone has any way to test those, > please do so. > > Eric Biggers (3): > crypto: s390/aes - convert to skcipher API > crypto: s390/paes - convert to skcipher API > crypto: s390/des - convert to skcipher API > > arch/s390/crypto/aes_s390.c | 609 ++++++++++++++--------------------- > arch/s390/crypto/des_s390.c | 419 ++++++++++-------------- > arch/s390/crypto/paes_s390.c | 414 ++++++++++-------------- > 3 files changed, 580 insertions(+), 862 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt