From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FAKE_REPLY_C,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23038CA9EA0 for ; Tue, 22 Oct 2019 09:24:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DED9C2064B for ; Tue, 22 Oct 2019 09:24:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="R3F5cO+r" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730247AbfJVJY1 (ORCPT ); Tue, 22 Oct 2019 05:24:27 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:36914 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728182AbfJVJY1 (ORCPT ); Tue, 22 Oct 2019 05:24:27 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9M9JU8i185942; Tue, 22 Oct 2019 09:23:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=++cgjjQ/jgmlwI3rDPAllCFU0ypC2zwR/EH/tCVXcuY=; b=R3F5cO+rqCFTw59Qhr3SYTlf2PkZT2idE8BVKKsHaJin+qrPNm6KnMhoeKLMdFKc9qEO fsW4SGW8prYghRkvbgRzC38LMSWKi3R7patJVssDcsqogagNuoI3I/V6dmU4+j0FRfV5 +RPO+TY21lJN5uBhsfH6xIOepme7PbhdPrrdyh1IyJ2HV6An8sVJm7O3SyeIHjF0rQHm 0ivQwNJePmziXVQuJaMipaT/cqV+KG6VxLuMWY4W93bFrPUW3FnB0mcATSUWZH8IWQ7Y VeY/XS394I2IQCTgkAjxu0yERIBbmn7XMkOCYbIGo5NP75KUjzK2NS7ZwHdFL62PcaUf Ew== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 2vqswtdekj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 22 Oct 2019 09:23:40 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x9M9NLn9156690; Tue, 22 Oct 2019 09:23:40 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 2vsx22bepv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 22 Oct 2019 09:23:39 +0000 Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x9M9NXj0032288; Tue, 22 Oct 2019 09:23:33 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 22 Oct 2019 02:23:32 -0700 Date: Tue, 22 Oct 2019 12:23:12 +0300 From: Dan Carpenter To: kbuild@lists.01.org, Corentin Labbe Cc: kbuild-all@lists.01.org, catalin.marinas@arm.com, davem@davemloft.net, herbert@gondor.apana.org.au, linux@armlinux.org.uk, mark.rutland@arm.com, mripard@kernel.org, robh+dt@kernel.org, wens@csie.org, will@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, Corentin Labbe Subject: Re: [PATCH v4 02/11] crypto: Add Allwinner sun8i-ce Crypto Engine Message-ID: <20191022092312.GC10833@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191012184852.28329-3-clabbe.montjoie@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9417 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910220087 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9417 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910220087 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Hi Corentin, url: https://github.com/0day-ci/linux/commits/Corentin-Labbe/crypto-add-sun8i-ce-driver-for-Allwinner-crypto-engine/20191014-104401 base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master If you fix the issue, kindly add following tag Reported-by: kbuild test robot Reported-by: Dan Carpenter smatch warnings: drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c:371 sun8i_ce_allocate_chanlist() error: uninitialized symbol 'err'. # https://github.com/0day-ci/linux/commit/f113059e7b4f94c545994aeafdc809a3e4907ae4 git remote add linux-review https://github.com/0day-ci/linux git remote update linux-review git checkout f113059e7b4f94c545994aeafdc809a3e4907ae4 vim +/err +371 drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c f113059e7b4f94 Corentin Labbe 2019-10-12 334 static int sun8i_ce_allocate_chanlist(struct sun8i_ce_dev *ce) f113059e7b4f94 Corentin Labbe 2019-10-12 335 { f113059e7b4f94 Corentin Labbe 2019-10-12 336 int i, err; f113059e7b4f94 Corentin Labbe 2019-10-12 337 f113059e7b4f94 Corentin Labbe 2019-10-12 338 ce->chanlist = devm_kcalloc(ce->dev, MAXFLOW, f113059e7b4f94 Corentin Labbe 2019-10-12 339 sizeof(struct sun8i_ce_flow), GFP_KERNEL); f113059e7b4f94 Corentin Labbe 2019-10-12 340 if (!ce->chanlist) f113059e7b4f94 Corentin Labbe 2019-10-12 341 return -ENOMEM; f113059e7b4f94 Corentin Labbe 2019-10-12 342 f113059e7b4f94 Corentin Labbe 2019-10-12 343 for (i = 0; i < MAXFLOW; i++) { f113059e7b4f94 Corentin Labbe 2019-10-12 344 init_completion(&ce->chanlist[i].complete); f113059e7b4f94 Corentin Labbe 2019-10-12 345 f113059e7b4f94 Corentin Labbe 2019-10-12 346 ce->chanlist[i].engine = crypto_engine_alloc_init(ce->dev, true); f113059e7b4f94 Corentin Labbe 2019-10-12 347 if (!ce->chanlist[i].engine) { f113059e7b4f94 Corentin Labbe 2019-10-12 348 dev_err(ce->dev, "Cannot allocate engine\n"); f113059e7b4f94 Corentin Labbe 2019-10-12 349 i--; f113059e7b4f94 Corentin Labbe 2019-10-12 350 goto error_engine; err = -ENOMEM; f113059e7b4f94 Corentin Labbe 2019-10-12 351 } f113059e7b4f94 Corentin Labbe 2019-10-12 352 err = crypto_engine_start(ce->chanlist[i].engine); f113059e7b4f94 Corentin Labbe 2019-10-12 353 if (err) { f113059e7b4f94 Corentin Labbe 2019-10-12 354 dev_err(ce->dev, "Cannot start engine\n"); f113059e7b4f94 Corentin Labbe 2019-10-12 355 goto error_engine; f113059e7b4f94 Corentin Labbe 2019-10-12 356 } f113059e7b4f94 Corentin Labbe 2019-10-12 357 ce->chanlist[i].tl = dma_alloc_coherent(ce->dev, f113059e7b4f94 Corentin Labbe 2019-10-12 358 sizeof(struct ce_task), f113059e7b4f94 Corentin Labbe 2019-10-12 359 &ce->chanlist[i].t_phy, f113059e7b4f94 Corentin Labbe 2019-10-12 360 GFP_KERNEL); f113059e7b4f94 Corentin Labbe 2019-10-12 361 if (!ce->chanlist[i].tl) { f113059e7b4f94 Corentin Labbe 2019-10-12 362 dev_err(ce->dev, "Cannot get DMA memory for task %d\n", f113059e7b4f94 Corentin Labbe 2019-10-12 363 i); f113059e7b4f94 Corentin Labbe 2019-10-12 364 err = -ENOMEM; f113059e7b4f94 Corentin Labbe 2019-10-12 365 goto error_engine; f113059e7b4f94 Corentin Labbe 2019-10-12 366 } f113059e7b4f94 Corentin Labbe 2019-10-12 367 } f113059e7b4f94 Corentin Labbe 2019-10-12 368 return 0; f113059e7b4f94 Corentin Labbe 2019-10-12 369 error_engine: f113059e7b4f94 Corentin Labbe 2019-10-12 370 sun8i_ce_free_chanlist(ce, i); f113059e7b4f94 Corentin Labbe 2019-10-12 @371 return err; f113059e7b4f94 Corentin Labbe 2019-10-12 372 } --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation