From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9DF1CA9EAE for ; Tue, 29 Oct 2019 12:32:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BAAE92086A for ; Tue, 29 Oct 2019 12:32:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="aMwSkpUU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728432AbfJ2Mb7 (ORCPT ); Tue, 29 Oct 2019 08:31:59 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:51542 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726875AbfJ2Mb7 (ORCPT ); Tue, 29 Oct 2019 08:31:59 -0400 Received: by mail-wm1-f68.google.com with SMTP id q70so2389193wme.1 for ; Tue, 29 Oct 2019 05:31:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=xhbeap0zYq8ygksM/mgoVa+Q+7s8AmV30mQ95BsGCuI=; b=aMwSkpUUD4qCjCpYYh/dcGfZlB4t4tBaRbhrhL5fDucT5n7u0Ynl3DtWQQwf4HlCTM rKFMOHpNkXgVmOAd4mmFVOdyGb+fsnND/8mLve+obduh6/AL1DnAU4t1XILZqJOLlUjF ZagYWfnBaHNPpPOPsqAGeyUk9QIBLNONLRNrARMybq/lB8q4pxNeD2tsa1kDnn5O51ag sD5737K5U1pwBa7gVr0PC6xsFtc6MWUcKe0KY5U+ut9aSdCmRtcKnZnIKy/JHlhq6HUD ayWw49ec8kSC4nWIapkQpGYPADXHMVfHaxhWrSOyCSQ15DoULCFPOiB6Z8BL6y2t5gVJ EFXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=xhbeap0zYq8ygksM/mgoVa+Q+7s8AmV30mQ95BsGCuI=; b=i7175lEAhksLG426FcmDBBQT/kYWzvPVzMd0S1uKtWQntsEsezhPzGg+6aU+9PK19s JbygYxnGBsH6Gbry2XG80Bb0r79wJQ7qxZhRxDjUsu8q1z+zyx9cuGCuRC//oYPMIthF 0bBe5wjF6yXDSGlQtj9dUZAkQZ2GbSyVP5g4ujthh5ZW8Qnl0OYyezKyJvGCJy+Ss4jW FkTB83/0IjYANeHqW+EV+8XZ+gP0qHrIO27tL0wmd1B3qH4mNDYlKBR7Gc/FruUXW2Gd cXWD5x2Y6FOAQROQ9iSBb3Gy34HDaeuh67NpY6YSpvUWYneWYKY+RbVvt4bSJ6AR84Kf +NuQ== X-Gm-Message-State: APjAAAXvQxwDsC06E1xDXc88WrOT7yrzDtflOrpbgTHePMyx4vzdt4lT sgDDbGhbsk/YI3woBm/cmeyguQ== X-Google-Smtp-Source: APXvYqyHjKu+2Ja4N9z0bwSJPnfrhxCySVoKSvAPuhefGUh9brsbc6qd1X+u4ZTKMm2DxUjis/WSXQ== X-Received: by 2002:a1c:560b:: with SMTP id k11mr4182419wmb.153.1572352317183; Tue, 29 Oct 2019 05:31:57 -0700 (PDT) Received: from Red ([2a01:cb1d:147:7200:2e56:dcff:fed2:c6d6]) by smtp.googlemail.com with ESMTPSA id s13sm2874256wmc.28.2019.10.29.05.31.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Oct 2019 05:31:55 -0700 (PDT) Date: Tue, 29 Oct 2019 13:31:52 +0100 From: LABBE Corentin To: Colin King Cc: Herbert Xu , "David S . Miller" , Neil Armstrong , linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] crypto: amlogic: ensure error variable err is set before returning it Message-ID: <20191029123152.GA18754@Red> References: <20191029113230.7050-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191029113230.7050-1-colin.king@canonical.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Oct 29, 2019 at 11:32:30AM +0000, Colin King wrote: > From: Colin Ian King > > Currently when the call to crypto_engine_alloc_init fails the error > return path returns an uninitialized value in the variable err. Fix > this by setting err to -ENOMEM. > > Addresses-Coverity: ("Uninitialized scalar variable") > Fixes: 48fe583fe541 ("crypto: amlogic - Add crypto accelerator for amlogic GXL") > Signed-off-by: Colin Ian King > --- > drivers/crypto/amlogic/amlogic-gxl-core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/crypto/amlogic/amlogic-gxl-core.c b/drivers/crypto/amlogic/amlogic-gxl-core.c > index db5b421e88d8..fa05fce1c0de 100644 > --- a/drivers/crypto/amlogic/amlogic-gxl-core.c > +++ b/drivers/crypto/amlogic/amlogic-gxl-core.c > @@ -162,6 +162,7 @@ static int meson_allocate_chanlist(struct meson_dev *mc) > if (!mc->chanlist[i].engine) { > dev_err(mc->dev, "Cannot allocate engine\n"); > i--; > + err = -ENOMEM; > goto error_engine; > } > err = crypto_engine_start(mc->chanlist[i].engine); > -- > 2.20.1 > Acked-by: Corentin Labbe Thanks