From: Herbert Xu <herbert@gondor.apana.org.au>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Antoine Tenart <antoine.tenart@bootlin.com>,
"David S. Miller" <davem@davemloft.net>,
Pascal van Leeuwen <pvanleeuwen@verimatrix.com>,
Pascal van Leeuwen <pascalvanl@gmail.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v2] crypto: inside-secure - Reduce stack usage
Date: Fri, 1 Nov 2019 13:39:31 +0800 [thread overview]
Message-ID: <20191101053931.i7yoxhptrftu537m@gondor.apana.org.au> (raw)
In-Reply-To: <20191022151421.2070738-1-arnd@arndb.de>
On Tue, Oct 22, 2019 at 05:14:13PM +0200, Arnd Bergmann wrote:
>
> case CONTEXT_CONTROL_CRYPTO_ALG_SM3:
> if (safexcel_hmac_setkey("safexcel-sm3", keys.authkey,
> - keys.authkeylen, &istate, &ostate))
> + keys.authkeylen, &state[0], &state[1]))
> goto badkey;
Any reason why this one remains as "goto badkey" instead of
badkey_free?
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2019-11-01 5:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 15:14 [PATCH] [v2] crypto: inside-secure - Reduce stack usage Arnd Bergmann
2019-11-01 5:39 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191101053931.i7yoxhptrftu537m@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=antoine.tenart@bootlin.com \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pascalvanl@gmail.com \
--cc=pvanleeuwen@verimatrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).