[cryptodev:master 150/163] drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c:558:52-53: Unneeded semicolon

[cryptodev:master 150/163] drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c:558:52-53: Unneeded semicolon

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
head:   298b4c604008025b134bc6fccbc4018449945d60
commit: 06f751b613296cc34b86fc83fccaf30d646eb8bc [150/163] crypto: allwinner - Add sun8i-ce Crypto Engine

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>


coccinelle warnings: (new ones prefixed by >>)

>> drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c:558:52-53: Unneeded semicolon

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[PATCH] crypto: fix semicolon.cocci warnings

[kbuild test robot]

From: kbuild test robot <lkp@intel.com>

drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c:558:52-53: Unneeded semicolon


 Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

Fixes: 06f751b61329 ("crypto: allwinner - Add sun8i-ce Crypto Engine")
CC: Corentin Labbe <clabbe.montjoie@gmail.com>
Signed-off-by: kbuild test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
head:   298b4c604008025b134bc6fccbc4018449945d60
commit: 06f751b613296cc34b86fc83fccaf30d646eb8bc [150/163] crypto: allwinner - Add sun8i-ce Crypto Engine

 sun8i-ce-core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c
+++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c
@@ -555,7 +555,7 @@ static int sun8i_ce_probe(struct platfor
 		return -EINVAL;
 	}
 
-	ce->base = devm_platform_ioremap_resource(pdev, 0);;
+	ce->base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(ce->base))
 		return PTR_ERR(ce->base);
 

[PATCH] crypto: fix semicolon.cocci warnings

[kernel test robot]

From: kernel test robot <lkp@intel.com>

drivers/crypto/ccp/sev-dev.c:263:2-3: Unneeded semicolon


 Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

Fixes: 3d725965f836 ("crypto: ccp - Add SEV_INIT_EX support")
CC: David Rientjes <rientjes@google.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
head:   696645d25bafd6ba3562611c29bc8ecd47066dfe
commit: 3d725965f836a7acbd1674e33644bec18373de53 [83/95] crypto: ccp - Add SEV_INIT_EX support
:::::: branch date: 31 hours ago
:::::: commit date: 31 hours ago

 sev-dev.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/crypto/ccp/sev-dev.c
+++ b/drivers/crypto/ccp/sev-dev.c
@@ -260,7 +260,7 @@ static void sev_write_init_ex_file_if_re
 		break;
 	default:
 		return;
-	};
+	}
 
 	sev_write_init_ex_file();
 }

Re: [PATCH] crypto: fix semicolon.cocci warnings

[Herbert Xu]

On Sat, Dec 18, 2021 at 09:25:42PM +0800, kernel test robot wrote:
> From: kernel test robot <lkp@intel.com>
> 
> drivers/crypto/ccp/sev-dev.c:263:2-3: Unneeded semicolon
> 
> 
>  Remove unneeded semicolon.
> 
> Generated by: scripts/coccinelle/misc/semicolon.cocci
> 
> Fixes: 3d725965f836 ("crypto: ccp - Add SEV_INIT_EX support")
> CC: David Rientjes <rientjes@google.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
> head:   696645d25bafd6ba3562611c29bc8ecd47066dfe
> commit: 3d725965f836a7acbd1674e33644bec18373de53 [83/95] crypto: ccp - Add SEV_INIT_EX support
> :::::: branch date: 31 hours ago
> :::::: commit date: 31 hours ago
> 
>  sev-dev.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I don't know what happened but your patch isn't in patchwork.
Could you please try resending?

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: fix semicolon.cocci warnings

[Peter Gonda]

On Thu, Dec 23, 2021 at 8:28 PM Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> On Sat, Dec 18, 2021 at 09:25:42PM +0800, kernel test robot wrote:
> > From: kernel test robot <lkp@intel.com>
> >
> > drivers/crypto/ccp/sev-dev.c:263:2-3: Unneeded semicolon
> >
> >
> >  Remove unneeded semicolon.
> >
> > Generated by: scripts/coccinelle/misc/semicolon.cocci
> >
> > Fixes: 3d725965f836 ("crypto: ccp - Add SEV_INIT_EX support")
> > CC: David Rientjes <rientjes@google.com>
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: kernel test robot <lkp@intel.com>
> > ---
> >
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
> > head:   696645d25bafd6ba3562611c29bc8ecd47066dfe
> > commit: 3d725965f836a7acbd1674e33644bec18373de53 [83/95] crypto: ccp - Add SEV_INIT_EX support
> > :::::: branch date: 31 hours ago
> > :::::: commit date: 31 hours ago
> >
> >  sev-dev.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> I don't know what happened but your patch isn't in patchwork.
> Could you please try resending?

Herbert I see the patches I sent here:
https://patchwork.kernel.org/project/linux-crypto/list/?series=591933&state=%2A&archive=both.

Are you asking for this bot to resend? Or should I send a fix up patch
if that's easier.

>
> Thanks,
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: fix semicolon.cocci warnings

[Herbert Xu]

On Tue, Jan 04, 2022 at 02:14:16PM -0700, Peter Gonda wrote:
>
> Herbert I see the patches I sent here:
> https://patchwork.kernel.org/project/linux-crypto/list/?series=591933&state=%2A&archive=both.

I meant the bot's patch.

> Are you asking for this bot to resend? Or should I send a fix up patch
> if that's easier.

If you could resend the bot's fix up patch that would be great.

Thanks!
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: fix semicolon.cocci warnings

[Peter Gonda]

On Tue, Jan 4, 2022 at 5:30 PM Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> On Tue, Jan 04, 2022 at 02:14:16PM -0700, Peter Gonda wrote:
> >
> > Herbert I see the patches I sent here:
> > https://patchwork.kernel.org/project/linux-crypto/list/?series=591933&state=%2A&archive=both.
>
> I meant the bot's patch.
>
> > Are you asking for this bot to resend? Or should I send a fix up patch
> > if that's easier.
>
> If you could resend the bot's fix up patch that would be great.

My mistake, I should have checked first. Someone has already done
this: https://patchwork.kernel.org/project/linux-crypto/patch/20211221003828.101022-1-yang.lee@linux.alibaba.com/
.
>
> Thanks!
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[PATCH] crypto: fix semicolon.cocci warnings

[Julia Lawall]

From: kbuild test robot <lkp@intel.com>

 Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

Fixes: f08fcced6d00 ("crypto: allwinner - Add sun8i-ss cryptographic offloader")
CC: Corentin Labbe <clabbe.montjoie@gmail.com>
Signed-off-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
head:   298b4c604008025b134bc6fccbc4018449945d60
commit: f08fcced6d0017c39cb6eccb571290867119d049 [154/163] crypto: allwinner - Add sun8i-ss cryptographic offloader
:::::: branch date: 3 hours ago
:::::: commit date: 3 hours ago

 sun8i-ss-core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
+++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
@@ -528,7 +528,7 @@ static int sun8i_ss_probe(struct platfor
 		return -EINVAL;
 	}

-	ss->base = devm_platform_ioremap_resource(pdev, 0);;
+	ss->base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(ss->base))
 		return PTR_ERR(ss->base);

Re: [PATCH] crypto: fix semicolon.cocci warnings

[Corentin Labbe]

On Fri, Nov 01, 2019 at 09:52:06AM +0100, Julia Lawall wrote:
> From: kbuild test robot <lkp@intel.com>
> 
>  Remove unneeded semicolon.
> 
> Generated by: scripts/coccinelle/misc/semicolon.cocci
> 
> Fixes: f08fcced6d00 ("crypto: allwinner - Add sun8i-ss cryptographic offloader")
> CC: Corentin Labbe <clabbe.montjoie@gmail.com>
> Signed-off-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> ---

Acked-by: Corentin Labbe <clabbe.montjoie@gmail.com>

Thanks

Re: [PATCH] crypto: fix semicolon.cocci warnings

[Herbert Xu]

On Fri, Nov 01, 2019 at 09:52:06AM +0100, Julia Lawall wrote:
> From: kbuild test robot <lkp@intel.com>
> 
>  Remove unneeded semicolon.
> 
> Generated by: scripts/coccinelle/misc/semicolon.cocci
> 
> Fixes: f08fcced6d00 ("crypto: allwinner - Add sun8i-ss cryptographic offloader")
> CC: Corentin Labbe <clabbe.montjoie@gmail.com>
> Signed-off-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
> head:   298b4c604008025b134bc6fccbc4018449945d60
> commit: f08fcced6d0017c39cb6eccb571290867119d049 [154/163] crypto: allwinner - Add sun8i-ss cryptographic offloader
> :::::: branch date: 3 hours ago
> :::::: commit date: 3 hours ago
> 
>  sun8i-ss-core.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[cryptodev:master 47/51] crypto/drbg.c:1637:39-40: Unneeded semicolon

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
head:   5a7de97309f5af4458b1a25a2a529a1a893c5269
commit: 355912852115cd8aa4ad02c25182ae615ce925fb [47/51] crypto: drbg - use CTR AES instead of ECB AES


coccinelle warnings: (new ones prefixed by >>)

>> crypto/drbg.c:1637:39-40: Unneeded semicolon

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[PATCH] crypto: fix semicolon.cocci warnings

[kbuild test robot]

crypto/drbg.c:1637:39-40: Unneeded semicolon


 Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

CC: Stephan Mueller <smueller@chronox.de>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 drbg.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/crypto/drbg.c
+++ b/crypto/drbg.c
@@ -1634,7 +1634,7 @@ static int drbg_fini_sym_kernel(struct d
 	drbg->ctr_handle = NULL;
 
 	if (drbg->ctr_req)
-		skcipher_request_free(drbg->ctr_req);;
+		skcipher_request_free(drbg->ctr_req);
 	drbg->ctr_req = NULL;
 
 	kfree(drbg->ctr_null_value_buf);

Re: [PATCH] crypto: fix semicolon.cocci warnings

[Stephan Mueller]

Am Mittwoch, 15. Juni 2016, 19:13:25 schrieb kbuild test robot:

Hi Fengguang,

> crypto/drbg.c:1637:39-40: Unneeded semicolon
> 
> 
>  Remove unneeded semicolon.

Thank you!

> 
> Generated by: scripts/coccinelle/misc/semicolon.cocci
> 
> CC: Stephan Mueller <smueller@chronox.de>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Acked-by: Stephan Mueller <smueller@chronox.de>
> ---
> 
>  drbg.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/crypto/drbg.c
> +++ b/crypto/drbg.c
> @@ -1634,7 +1634,7 @@ static int drbg_fini_sym_kernel(struct d
>  	drbg->ctr_handle = NULL;
> 
>  	if (drbg->ctr_req)
> -		skcipher_request_free(drbg->ctr_req);;
> +		skcipher_request_free(drbg->ctr_req);
>  	drbg->ctr_req = NULL;
> 
>  	kfree(drbg->ctr_null_value_buf);


Ciao
Stephan

Re: [PATCH] crypto: fix semicolon.cocci warnings

[Herbert Xu]

On Wed, Jun 15, 2016 at 07:13:25PM +0800, kbuild test robot wrote:
> crypto/drbg.c:1637:39-40: Unneeded semicolon
> 
> 
>  Remove unneeded semicolon.
> 
> Generated by: scripts/coccinelle/misc/semicolon.cocci
> 
> CC: Stephan Mueller <smueller@chronox.de>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt