From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39C56FA372C for ; Fri, 8 Nov 2019 09:16:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0F0B421D6C for ; Fri, 8 Nov 2019 09:16:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730733AbfKHJQV (ORCPT ); Fri, 8 Nov 2019 04:16:21 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:36866 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730281AbfKHJQV (ORCPT ); Fri, 8 Nov 2019 04:16:21 -0500 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1iT0NG-00020V-C1; Fri, 08 Nov 2019 17:16:10 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1iT0NE-0002Ll-H0; Fri, 08 Nov 2019 17:16:08 +0800 Date: Fri, 8 Nov 2019 17:16:08 +0800 From: Herbert Xu To: Tero Kristo Cc: Gilad Ben-Yossef , David Miller , Linux Crypto Mailing List , Ard Biesheuvel , linux-omap@vger.kernel.org, Linux ARM Subject: Re: [PATCH 09/10] crypto: add timeout to crypto_wait_req Message-ID: <20191108091608.i5fxt2vu2nwrybgn@gondor.apana.org.au> References: <20191017122549.4634-1-t-kristo@ti.com> <20191017122549.4634-10-t-kristo@ti.com> <076f0bc6-ad04-9543-db02-d7c7060db036@ti.com> <20191108022759.GB1140@sol.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Nov 08, 2019 at 09:40:57AM +0200, Tero Kristo wrote: > > The problem is not detecting a hung task, the problem is determining what > caused the hang. Personally I don't care if the system dies if a crypto > accelerator self test has failed, as long as I get reported about the exact > nature of the failure. The failures are expected to happen only in > development phase of a crypto driver. > > With the timeout patch in place, I get reported what exact crypto test case > failed and I can focus my debug efforts on that one. If that's all you need then how about just making the wait killable? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt