Linux-Crypto Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH -next] crypto: sun8i-ss - Fix memdup.cocci warnings
@ 2019-11-09  2:44 YueHaibing
  2019-11-12  7:03 ` Corentin Labbe
  2019-11-12  7:23 ` [PATCH v2 -next] crypto: sun8i-ce " YueHaibing
  0 siblings, 2 replies; 5+ messages in thread
From: YueHaibing @ 2019-11-09  2:44 UTC (permalink / raw)
  To: Corentin Labbe, Herbert Xu, Maxime Ripard, Chen-Yu Tsai
  Cc: YueHaibing, linux-crypto, linux-arm-kernel, linux-kernel,
	kernel-janitors

Use kmemdup rather than duplicating its implementation

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
index f0e7c1e12da6..b6e7c346c3ae 100644
--- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
+++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
@@ -396,10 +396,9 @@ int sun8i_ce_aes_setkey(struct crypto_skcipher *tfm, const u8 *key,
 		kfree(op->key);
 	}
 	op->keylen = keylen;
-	op->key = kmalloc(keylen, GFP_KERNEL | GFP_DMA);
+	op->key = kmemdup(key, keylen, GFP_KERNEL | GFP_DMA);
 	if (!op->key)
 		return -ENOMEM;
-	memcpy(op->key, key, keylen);
 
 	crypto_sync_skcipher_clear_flags(op->fallback_tfm, CRYPTO_TFM_REQ_MASK);
 	crypto_sync_skcipher_set_flags(op->fallback_tfm, tfm->base.crt_flags & CRYPTO_TFM_REQ_MASK);
@@ -422,10 +421,9 @@ int sun8i_ce_des3_setkey(struct crypto_skcipher *tfm, const u8 *key,
 		kfree(op->key);
 	}
 	op->keylen = keylen;
-	op->key = kmalloc(keylen, GFP_KERNEL | GFP_DMA);
+	op->key = kmemdup(key, keylen, GFP_KERNEL | GFP_DMA);
 	if (!op->key)
 		return -ENOMEM;
-	memcpy(op->key, key, keylen);
 
 	crypto_sync_skcipher_clear_flags(op->fallback_tfm, CRYPTO_TFM_REQ_MASK);
 	crypto_sync_skcipher_set_flags(op->fallback_tfm, tfm->base.crt_flags & CRYPTO_TFM_REQ_MASK);




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH -next] crypto: sun8i-ss - Fix memdup.cocci warnings
  2019-11-09  2:44 [PATCH -next] crypto: sun8i-ss - Fix memdup.cocci warnings YueHaibing
@ 2019-11-12  7:03 ` Corentin Labbe
  2019-11-12  7:08   ` Yuehaibing
  2019-11-12  7:23 ` [PATCH v2 -next] crypto: sun8i-ce " YueHaibing
  1 sibling, 1 reply; 5+ messages in thread
From: Corentin Labbe @ 2019-11-12  7:03 UTC (permalink / raw)
  To: YueHaibing
  Cc: Herbert Xu, Maxime Ripard, Chen-Yu Tsai, linux-crypto,
	linux-arm-kernel, linux-kernel, kernel-janitors

On Sat, Nov 09, 2019 at 02:44:03AM +0000, YueHaibing wrote:
> Use kmemdup rather than duplicating its implementation
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---

Hello

Thanks but the patch was already sent by kbuild robot and merged.

Regards

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH -next] crypto: sun8i-ss - Fix memdup.cocci warnings
  2019-11-12  7:03 ` Corentin Labbe
@ 2019-11-12  7:08   ` Yuehaibing
  0 siblings, 0 replies; 5+ messages in thread
From: Yuehaibing @ 2019-11-12  7:08 UTC (permalink / raw)
  To: Corentin Labbe
  Cc: Herbert Xu, Maxime Ripard, Chen-Yu Tsai, linux-crypto,
	linux-arm-kernel, linux-kernel, kernel-janitors

On 2019/11/12 15:03, Corentin Labbe wrote:
> On Sat, Nov 09, 2019 at 02:44:03AM +0000, YueHaibing wrote:
>> Use kmemdup rather than duplicating its implementation
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
> 
> Hello
> 
> Thanks but the patch was already sent by kbuild robot and merged.

Sorry, this patch title should be "sun8i-ce" instead of "sun8i-ss",

kbuild robot indeed fix 'sun8i-ss' warning,  will resend v2.

> 
> Regards
> 
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2 -next] crypto: sun8i-ce - Fix memdup.cocci warnings
  2019-11-09  2:44 [PATCH -next] crypto: sun8i-ss - Fix memdup.cocci warnings YueHaibing
  2019-11-12  7:03 ` Corentin Labbe
@ 2019-11-12  7:23 ` " YueHaibing
  2019-11-16 19:47   ` Corentin Labbe
  1 sibling, 1 reply; 5+ messages in thread
From: YueHaibing @ 2019-11-12  7:23 UTC (permalink / raw)
  To: Corentin Labbe, Herbert Xu, Maxime Ripard, Chen-Yu Tsai
  Cc: YueHaibing, linux-crypto, linux-arm-kernel, linux-kernel,
	kernel-janitors

Use kmemdup rather than duplicating its implementation

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
v2: fix patch title 'sun8i-ss' -> 'sun8i-ce'
---
 drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
index f0e7c1e12da6..b6e7c346c3ae 100644
--- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
+++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
@@ -396,10 +396,9 @@ int sun8i_ce_aes_setkey(struct crypto_skcipher *tfm, const u8 *key,
 		kfree(op->key);
 	}
 	op->keylen = keylen;
-	op->key = kmalloc(keylen, GFP_KERNEL | GFP_DMA);
+	op->key = kmemdup(key, keylen, GFP_KERNEL | GFP_DMA);
 	if (!op->key)
 		return -ENOMEM;
-	memcpy(op->key, key, keylen);
 
 	crypto_sync_skcipher_clear_flags(op->fallback_tfm, CRYPTO_TFM_REQ_MASK);
 	crypto_sync_skcipher_set_flags(op->fallback_tfm, tfm->base.crt_flags & CRYPTO_TFM_REQ_MASK);
@@ -422,10 +421,9 @@ int sun8i_ce_des3_setkey(struct crypto_skcipher *tfm, const u8 *key,
 		kfree(op->key);
 	}
 	op->keylen = keylen;
-	op->key = kmalloc(keylen, GFP_KERNEL | GFP_DMA);
+	op->key = kmemdup(key, keylen, GFP_KERNEL | GFP_DMA);
 	if (!op->key)
 		return -ENOMEM;
-	memcpy(op->key, key, keylen);
 
 	crypto_sync_skcipher_clear_flags(op->fallback_tfm, CRYPTO_TFM_REQ_MASK);
 	crypto_sync_skcipher_set_flags(op->fallback_tfm, tfm->base.crt_flags & CRYPTO_TFM_REQ_MASK);




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 -next] crypto: sun8i-ce - Fix memdup.cocci warnings
  2019-11-12  7:23 ` [PATCH v2 -next] crypto: sun8i-ce " YueHaibing
@ 2019-11-16 19:47   ` Corentin Labbe
  0 siblings, 0 replies; 5+ messages in thread
From: Corentin Labbe @ 2019-11-16 19:47 UTC (permalink / raw)
  To: YueHaibing
  Cc: Herbert Xu, Maxime Ripard, Chen-Yu Tsai, linux-crypto,
	linux-arm-kernel, linux-kernel, kernel-janitors

On Tue, Nov 12, 2019 at 07:23:14AM +0000, YueHaibing wrote:
> Use kmemdup rather than duplicating its implementation
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> v2: fix patch title 'sun8i-ss' -> 'sun8i-ce'
> ---
>  drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 

Acked-by: Corentin Labbe <clabbe.montjoie@gmail.com>

Thanks

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-09  2:44 [PATCH -next] crypto: sun8i-ss - Fix memdup.cocci warnings YueHaibing
2019-11-12  7:03 ` Corentin Labbe
2019-11-12  7:08   ` Yuehaibing
2019-11-12  7:23 ` [PATCH v2 -next] crypto: sun8i-ce " YueHaibing
2019-11-16 19:47   ` Corentin Labbe

Linux-Crypto Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-crypto/0 linux-crypto/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-crypto linux-crypto/ https://lore.kernel.org/linux-crypto \
		linux-crypto@vger.kernel.org
	public-inbox-index linux-crypto

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-crypto


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git