From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE276C17447 for ; Tue, 12 Nov 2019 03:16:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BCD9721872 for ; Tue, 12 Nov 2019 03:16:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726924AbfKLDQ6 (ORCPT ); Mon, 11 Nov 2019 22:16:58 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:38088 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726910AbfKLDQ6 (ORCPT ); Mon, 11 Nov 2019 22:16:58 -0500 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1iUMfY-0008Io-Cc; Tue, 12 Nov 2019 11:16:40 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1iUMfT-0007aI-9H; Tue, 12 Nov 2019 11:16:35 +0800 Date: Tue, 12 Nov 2019 11:16:35 +0800 From: Herbert Xu To: Stephan =?iso-8859-1?Q?M=FCller?= , Kees Cook , =?iso-8859-1?Q?Jo=E3o?= Moreira , Sami Tolvanen , "David S. Miller" , Ard Biesheuvel , x86@kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-hardening@lists.openwall.com Subject: Re: [PATCH v4 3/8] crypto: x86/camellia: Use new glue function macros Message-ID: <20191112031635.jm32vne33qxh7ojh@gondor.apana.org.au> References: <20191111214552.36717-1-keescook@chromium.org> <20191111214552.36717-4-keescook@chromium.org> <3059417.7DhL3USBNQ@positron.chronox.de> <20191112031417.GB1433@sol.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191112031417.GB1433@sol.localdomain> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, Nov 11, 2019 at 07:14:17PM -0800, Eric Biggers wrote: > > Also, I don't see the point of the macros, other than to obfuscate things. To > keep things straightforward, I think we should keep the explicit function > prototypes for each algorithm. I agree. Kees, please get rid of the macros. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt