Linux-Crypto Archive on lore.kernel.org
 help / color / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-crypto@vger.kernel.org, David Miller <davem@davemloft.net>,
	"Jason A . Donenfeld" <Jason@zx2c4.com>,
	Samuel Neves <sneves@dei.uc.pt>, Arnd Bergmann <arnd@arndb.de>,
	Eric Biggers <ebiggers@google.com>,
	Andy Lutomirski <luto@kernel.org>,
	Martin Willi <martin@strongswan.org>,
	Rene van Dorst <opensource@vdorst.com>,
	David Sterba <dsterba@suse.com>
Subject: Re: [PATCH v5 00/34] crypto: crypto API library interfaces for WireGuard
Date: Fri, 15 Nov 2019 14:07:27 +0800
Message-ID: <20191115060727.eng4657ym6obl4di@gondor.apana.org.au> (raw)
In-Reply-To: <20191108122240.28479-1-ardb@kernel.org>

On Fri, Nov 08, 2019 at 01:22:06PM +0100, Ard Biesheuvel wrote:
> This series implements the crypto library abstractions that are needed to
> incorporate WireGuard into the mainline kernel.
> 
> Changes since v4:
> - Address most review feedback from Eric, with the exception of the remark
>   about libraries being selectable by the user - this is something we need
>   to revisit in the context of moving to weak references or static calls to
>   make accelerated versions of libraries loadable at any time. (Currently,
>   loading an accelerated version at runtime will not supersede calls to the
>   generic routines in the kernel proper, which is counterintuitive, and this
>   is currently being addressed by making the generic library versions only
>   selectable as modules if the accelerated ones are selected as modules as
>   well)
> - Align the generic blake2s Kconfig symbols, filenames etc with the recently
>   added blake2b driver.
> - Rewrote the blake2s selftest for better coverage of key length and input
>   length combinations, and added a HMAC selftest as well.
> - Rename blake2s_hmac() to blake2s256_hmac(), and drop the digest length
>   argument, which was not implemented correctly, and never deviates from
>   the full length in practice anyway.
> - Update to more recent version of the blake2s x86 Zinc code
> 
> Changes since v3:
> - Unify the way the generic vs arch libraries are organized between ChaCha20
>   and Poly1305 on the one hand and Curve25519 and Blake2s on the other.
>   All are now made up of a generic library, a generic crypto API driver
>   (skcipher for [X]ChaCha, shash for Poly1305 and Blake2s and kpp for
>   Curve25519) and optional per-arch versions providing both the library and
>   the crypto API interfaces while potentially relying on the generic *library*
>   only as a fallback (and not on the generic crypto API driver). Implementations
>   of the libary interface that don't require the fallback don't pull in the
>   generic code at all, but the generic crypto API drivers are tied to the
>   generic implementations directly (this is necessary since we fuzz test the
>   accelerated implementations against the generic implementations)
> - Provide testmgr test vectors for the Curve25519 and Blake2s crypto API
>   drivers that were added in this revision. This also required some changes
>   to the KPP test routines so we can test for failures as well.
> - Update to the latest version of Andy Polyakov's Poly1305 implementation for
>   MIPS that incorporates Rene's improvements for 32r2
> - Remove logic in the x86 and ARM implementations of ChaCha and Poly1305 to
>   prefer the non-SIMD path for short inputs. This is no longer necessary, and
>   even undesirable since it forced ChaCha20Poly1305's ChaCha pass generating
>   the Poly1305 nonce to always take the slower scalar path.
> 
> Changes since v2:
> - Reduce the cc: audience a bit, since I assumed that not everyone is
>   interested in discussing the details of this.
> - Incorporate scalar ARM code for ChaCha, and the 64-bit MIPS code for
>   Poly1305. NOTE: the Cryptogams MIPS code now supports 32-bit MIPS as well,
>   and not just 32r2, so I omitted Rene's Poly1305 implementation for now, and
>   used Andy's code for everything.
> - Incorporate NEON opt-out for Cortex-A5/A7. Note that the code is still
>   exposed via the crypto API, but with a low prioririty, so it is still
>   available and still gets test coverage, but is not used by default.
> - Use static keys (*not* static calls) in the SIMD and bmi2/adx drivers to
>   keep track of which implementation is being used, to avoid the memory
>   load on each call.
> - Defer using weak references or static calls until the dust around this has
>   settled. Instead, rely on Kconfig constraints and symbol dependencies to
>   ensure that the arch code is always used when it is loaded. This means
>   you can only opt out of using the arch code if you disable it in Kconfig
>   but this is something I can live with for now.
> - Refactor the Curve25519 glue code slightly so that the call sites branch to
>   the arch or generic code directly.
> - Split up the Poly1305 refactoring patches so they can be reviewed more
>   easily.
> 
> Changes since RFC/v1:
> - dropped the WireGuard patch itself, and the followup patches - since the
>   purpose was to illustrate the extent of the required changes, there is no
>   reason to keep including them.
> - import the MIPS 32r2 versions of ChaCha and Poly1305, but expose both the
>   crypto API and library interfaces so that not only WireGuard but also IPsec
>   and Adiantum can benefit immediately. (The latter required adding support for
>   the reduced round version of ChaCha to the MIPS asm code)
> - fix up various minor kconfig/build issues found in randconfig testing
>   (thanks Arnd!)
> 
> Patches can be found here:
> https://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git/log/?h=wireguard-crypto-library-api-v5
> 
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: David Miller <davem@davemloft.net>
> Cc: Jason A. Donenfeld <Jason@zx2c4.com>
> Cc: Samuel Neves <sneves@dei.uc.pt>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Eric Biggers <ebiggers@google.com>
> Cc: Andy Lutomirski <luto@kernel.org>
> Cc: Martin Willi <martin@strongswan.org>
> Cc: Rene van Dorst <opensource@vdorst.com>
> Cc: David Sterba <dsterba@suse.com>
> 
> Ard Biesheuvel (27):
>   crypto: tidy up lib/crypto Kconfig and Makefile
>   crypto: chacha - move existing library code into lib/crypto
>   crypto: x86/chacha - depend on generic chacha library instead of
>     crypto driver
>   crypto: x86/chacha - expose SIMD ChaCha routine as library function
>   crypto: arm64/chacha - depend on generic chacha library instead of
>     crypto driver
>   crypto: arm64/chacha - expose arm64 ChaCha routine as library function
>   crypto: arm/chacha - import Eric Biggers's scalar accelerated ChaCha
>     code
>   crypto: arm/chacha - remove dependency on generic ChaCha driver
>   crypto: arm/chacha - expose ARM ChaCha routine as library function
>   crypto: mips/chacha - wire up accelerated 32r2 code from Zinc
>   crypto: chacha - unexport chacha_generic routines
>   crypto: poly1305 - move core routines into a separate library
>   crypto: x86/poly1305 - unify Poly1305 state struct with generic code
>   crypto: poly1305 - expose init/update/final library interface
>   crypto: x86/poly1305 - depend on generic library not generic shash
>   crypto: x86/poly1305 - expose existing driver as poly1305 library
>   crypto: arm64/poly1305 - incorporate OpenSSL/CRYPTOGAMS NEON
>     implementation
>   crypto: arm/poly1305 - incorporate OpenSSL/CRYPTOGAMS NEON
>     implementation
>   crypto: mips/poly1305 - incorporate OpenSSL/CRYPTOGAMS optimized
>     implementation
>   int128: move __uint128_t compiler test to Kconfig
>   crypto: testmgr - add test cases for Blake2s
>   crypto: blake2s - implement generic shash driver
>   crypto: curve25519 - add kpp selftest
>   crypto: curve25519 - implement generic KPP driver
>   crypto: lib/curve25519 - work around Clang stack spilling issue
>   crypto: chacha20poly1305 - import construction and selftest from Zinc
>   crypto: lib/chacha20poly1305 - reimplement crypt_from_sg() routine
> 
> Jason A. Donenfeld (7):
>   crypto: mips/chacha - import 32r2 ChaCha code from Zinc
>   crypto: BLAKE2s - generic C library implementation and selftest
>   crypto: BLAKE2s - x86_64 SIMD implementation
>   crypto: Curve25519 - generic C library implementations
>   crypto: Curve25519 - x86_64 library and KPP implementations
>   crypto: arm - import Bernstein and Schwabe's Curve25519 ARM
>     implementation
>   crypto: arm/Curve25519 - wire up NEON implementation
> 
>  arch/arm/crypto/Kconfig                   |   16 +-
>  arch/arm/crypto/Makefile                  |   17 +-
>  arch/arm/crypto/chacha-glue.c             |  343 +
>  arch/arm/crypto/chacha-neon-glue.c        |  202 -
>  arch/arm/crypto/chacha-scalar-core.S      |  460 ++
>  arch/arm/crypto/curve25519-core.S         | 2062 ++++++
>  arch/arm/crypto/curve25519-glue.c         |  127 +
>  arch/arm/crypto/poly1305-armv4.pl         | 1236 ++++
>  arch/arm/crypto/poly1305-core.S_shipped   | 1158 +++
>  arch/arm/crypto/poly1305-glue.c           |  276 +
>  arch/arm64/Kconfig                        |    2 +-
>  arch/arm64/crypto/Kconfig                 |    9 +-
>  arch/arm64/crypto/Makefile                |   10 +-
>  arch/arm64/crypto/chacha-neon-glue.c      |   81 +-
>  arch/arm64/crypto/poly1305-armv8.pl       |  913 +++
>  arch/arm64/crypto/poly1305-core.S_shipped |  835 +++
>  arch/arm64/crypto/poly1305-glue.c         |  237 +
>  arch/mips/Makefile                        |    2 +-
>  arch/mips/crypto/Makefile                 |   18 +
>  arch/mips/crypto/chacha-core.S            |  497 ++
>  arch/mips/crypto/chacha-glue.c            |  150 +
>  arch/mips/crypto/poly1305-glue.c          |  203 +
>  arch/mips/crypto/poly1305-mips.pl         | 1273 ++++
>  arch/riscv/Kconfig                        |    2 +-
>  arch/x86/Kconfig                          |    2 +-
>  arch/x86/crypto/Makefile                  |    3 +
>  arch/x86/crypto/blake2s-core.S            |  258 +
>  arch/x86/crypto/blake2s-glue.c            |  233 +
>  arch/x86/crypto/chacha_glue.c             |  181 +-
>  arch/x86/crypto/curve25519-x86_64.c       | 2475 +++++++
>  arch/x86/crypto/poly1305_glue.c           |  199 +-
>  crypto/Kconfig                            |   71 +-
>  crypto/Makefile                           |    2 +
>  crypto/adiantum.c                         |    5 +-
>  crypto/blake2s_generic.c                  |  171 +
>  crypto/chacha_generic.c                   |   84 +-
>  crypto/curve25519-generic.c               |   90 +
>  crypto/ecc.c                              |    2 +-
>  crypto/nhpoly1305.c                       |    3 +-
>  crypto/poly1305_generic.c                 |  228 +-
>  crypto/testmgr.c                          |   30 +
>  crypto/testmgr.h                          | 1520 +++-
>  include/crypto/blake2s.h                  |  106 +
>  include/crypto/chacha.h                   |   83 +-
>  include/crypto/chacha20poly1305.h         |   48 +
>  include/crypto/curve25519.h               |   71 +
>  include/crypto/internal/blake2s.h         |   24 +
>  include/crypto/internal/chacha.h          |   43 +
>  include/crypto/internal/poly1305.h        |   58 +
>  include/crypto/poly1305.h                 |   69 +-
>  init/Kconfig                              |    4 +
>  lib/Makefile                              |    3 +-
>  lib/crypto/Kconfig                        |  130 +
>  lib/crypto/Makefile                       |   42 +-
>  lib/crypto/blake2s-generic.c              |  111 +
>  lib/crypto/blake2s-selftest.c             |  622 ++
>  lib/crypto/blake2s.c                      |  126 +
>  lib/{ => crypto}/chacha.c                 |   20 +-
>  lib/crypto/chacha20poly1305-selftest.c    | 7393 ++++++++++++++++++++
>  lib/crypto/chacha20poly1305.c             |  369 +
>  lib/crypto/curve25519-fiat32.c            |  864 +++
>  lib/crypto/curve25519-hacl64.c            |  788 +++
>  lib/crypto/curve25519.c                   |   25 +
>  lib/crypto/libchacha.c                    |   35 +
>  lib/crypto/poly1305.c                     |  232 +
>  lib/ubsan.c                               |    2 +-
>  lib/ubsan.h                               |    2 +-
>  67 files changed, 26148 insertions(+), 808 deletions(-)
>  create mode 100644 arch/arm/crypto/chacha-glue.c
>  delete mode 100644 arch/arm/crypto/chacha-neon-glue.c
>  create mode 100644 arch/arm/crypto/chacha-scalar-core.S
>  create mode 100644 arch/arm/crypto/curve25519-core.S
>  create mode 100644 arch/arm/crypto/curve25519-glue.c
>  create mode 100644 arch/arm/crypto/poly1305-armv4.pl
>  create mode 100644 arch/arm/crypto/poly1305-core.S_shipped
>  create mode 100644 arch/arm/crypto/poly1305-glue.c
>  create mode 100644 arch/arm64/crypto/poly1305-armv8.pl
>  create mode 100644 arch/arm64/crypto/poly1305-core.S_shipped
>  create mode 100644 arch/arm64/crypto/poly1305-glue.c
>  create mode 100644 arch/mips/crypto/chacha-core.S
>  create mode 100644 arch/mips/crypto/chacha-glue.c
>  create mode 100644 arch/mips/crypto/poly1305-glue.c
>  create mode 100644 arch/mips/crypto/poly1305-mips.pl
>  create mode 100644 arch/x86/crypto/blake2s-core.S
>  create mode 100644 arch/x86/crypto/blake2s-glue.c
>  create mode 100644 arch/x86/crypto/curve25519-x86_64.c
>  create mode 100644 crypto/blake2s_generic.c
>  create mode 100644 crypto/curve25519-generic.c
>  create mode 100644 include/crypto/blake2s.h
>  create mode 100644 include/crypto/chacha20poly1305.h
>  create mode 100644 include/crypto/curve25519.h
>  create mode 100644 include/crypto/internal/blake2s.h
>  create mode 100644 include/crypto/internal/chacha.h
>  create mode 100644 include/crypto/internal/poly1305.h
>  create mode 100644 lib/crypto/Kconfig
>  create mode 100644 lib/crypto/blake2s-generic.c
>  create mode 100644 lib/crypto/blake2s-selftest.c
>  create mode 100644 lib/crypto/blake2s.c
>  rename lib/{ => crypto}/chacha.c (88%)
>  create mode 100644 lib/crypto/chacha20poly1305-selftest.c
>  create mode 100644 lib/crypto/chacha20poly1305.c
>  create mode 100644 lib/crypto/curve25519-fiat32.c
>  create mode 100644 lib/crypto/curve25519-hacl64.c
>  create mode 100644 lib/crypto/curve25519.c
>  create mode 100644 lib/crypto/libchacha.c
>  create mode 100644 lib/crypto/poly1305.c

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  parent reply index

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-08 12:22 Ard Biesheuvel
2019-11-08 12:22 ` [PATCH v5 01/34] crypto: tidy up lib/crypto Kconfig and Makefile Ard Biesheuvel
2019-11-08 12:22 ` [PATCH v5 02/34] crypto: chacha - move existing library code into lib/crypto Ard Biesheuvel
2019-11-08 12:22 ` [PATCH v5 03/34] crypto: x86/chacha - depend on generic chacha library instead of crypto driver Ard Biesheuvel
2019-11-08 12:22 ` [PATCH v5 04/34] crypto: x86/chacha - expose SIMD ChaCha routine as library function Ard Biesheuvel
2019-11-08 12:22 ` [PATCH v5 05/34] crypto: arm64/chacha - depend on generic chacha library instead of crypto driver Ard Biesheuvel
2019-11-08 12:22 ` [PATCH v5 06/34] crypto: arm64/chacha - expose arm64 ChaCha routine as library function Ard Biesheuvel
2019-11-08 12:22 ` [PATCH v5 07/34] crypto: arm/chacha - import Eric Biggers's scalar accelerated ChaCha code Ard Biesheuvel
2019-11-08 12:22 ` [PATCH v5 08/34] crypto: arm/chacha - remove dependency on generic ChaCha driver Ard Biesheuvel
2019-11-08 12:22 ` [PATCH v5 09/34] crypto: arm/chacha - expose ARM ChaCha routine as library function Ard Biesheuvel
2019-11-08 12:22 ` [PATCH v5 10/34] crypto: mips/chacha - import 32r2 ChaCha code from Zinc Ard Biesheuvel
2019-11-08 12:22 ` [PATCH v5 11/34] crypto: mips/chacha - wire up accelerated 32r2 " Ard Biesheuvel
2019-11-08 12:22 ` [PATCH v5 12/34] crypto: chacha - unexport chacha_generic routines Ard Biesheuvel
2019-11-08 12:22 ` [PATCH v5 13/34] crypto: poly1305 - move core routines into a separate library Ard Biesheuvel
2019-11-08 12:22 ` [PATCH v5 14/34] crypto: x86/poly1305 - unify Poly1305 state struct with generic code Ard Biesheuvel
2019-11-08 12:22 ` [PATCH v5 15/34] crypto: poly1305 - expose init/update/final library interface Ard Biesheuvel
2019-11-08 12:22 ` [PATCH v5 16/34] crypto: x86/poly1305 - depend on generic library not generic shash Ard Biesheuvel
2019-11-08 12:22 ` [PATCH v5 17/34] crypto: x86/poly1305 - expose existing driver as poly1305 library Ard Biesheuvel
2019-11-08 12:22 ` [PATCH v5 18/34] crypto: arm64/poly1305 - incorporate OpenSSL/CRYPTOGAMS NEON implementation Ard Biesheuvel
2019-11-08 12:22 ` [PATCH v5 19/34] crypto: arm/poly1305 " Ard Biesheuvel
2019-11-08 12:22 ` [PATCH v5 20/34] crypto: mips/poly1305 - incorporate OpenSSL/CRYPTOGAMS optimized implementation Ard Biesheuvel
2019-11-08 12:22 ` [PATCH v5 21/34] int128: move __uint128_t compiler test to Kconfig Ard Biesheuvel
2019-11-08 12:22 ` [PATCH v5 22/34] crypto: BLAKE2s - generic C library implementation and selftest Ard Biesheuvel
2019-11-08 12:22 ` [PATCH v5 23/34] crypto: testmgr - add test cases for Blake2s Ard Biesheuvel
2019-11-08 12:22 ` [PATCH v5 24/34] crypto: blake2s - implement generic shash driver Ard Biesheuvel
2019-11-08 12:22 ` [PATCH v5 25/34] crypto: BLAKE2s - x86_64 SIMD implementation Ard Biesheuvel
2019-11-08 12:22 ` [PATCH v5 26/34] crypto: Curve25519 - generic C library implementations Ard Biesheuvel
2019-11-08 12:22 ` [PATCH v5 27/34] crypto: curve25519 - add kpp selftest Ard Biesheuvel
2019-11-08 12:22 ` [PATCH v5 28/34] crypto: curve25519 - implement generic KPP driver Ard Biesheuvel
2019-11-08 12:22 ` [PATCH v5 29/34] crypto: lib/curve25519 - work around Clang stack spilling issue Ard Biesheuvel
2019-11-08 12:22 ` [PATCH v5 30/34] crypto: Curve25519 - x86_64 library and KPP implementations Ard Biesheuvel
2019-11-08 12:22 ` [PATCH v5 31/34] crypto: arm - import Bernstein and Schwabe's Curve25519 ARM implementation Ard Biesheuvel
2019-11-08 12:22 ` [PATCH v5 32/34] crypto: arm/Curve25519 - wire up NEON implementation Ard Biesheuvel
2019-11-08 12:22 ` [PATCH v5 33/34] crypto: chacha20poly1305 - import construction and selftest from Zinc Ard Biesheuvel
2019-11-08 12:22 ` [PATCH v5 34/34] crypto: lib/chacha20poly1305 - reimplement crypt_from_sg() routine Ard Biesheuvel
2019-11-15  6:07 ` Herbert Xu [this message]
     [not found]   ` <CAHmME9oOfhv6RN00m1c6c5qELC5dzFKS=mgDBQ-stVEWu00p_A@mail.gmail.com>
2019-11-15  9:09     ` [PATCH v5 00/34] crypto: crypto API library interfaces for WireGuard Herbert Xu
2019-11-19 15:18       ` Jason A. Donenfeld
2019-11-19 15:34         ` Ard Biesheuvel
2019-11-19 15:44           ` Jason A. Donenfeld
2019-11-19 15:59             ` Ard Biesheuvel
2019-11-19 16:23             ` Eric Biggers
2019-11-19 21:43               ` Jordan Glover

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191115060727.eng4657ym6obl4di@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=Jason@zx2c4.com \
    --cc=ardb@kernel.org \
    --cc=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=dsterba@suse.com \
    --cc=ebiggers@google.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=martin@strongswan.org \
    --cc=opensource@vdorst.com \
    --cc=sneves@dei.uc.pt \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Crypto Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-crypto/0 linux-crypto/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-crypto linux-crypto/ https://lore.kernel.org/linux-crypto \
		linux-crypto@vger.kernel.org
	public-inbox-index linux-crypto

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-crypto


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git