From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58BB4C432C0 for ; Sun, 17 Nov 2019 00:57:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2A6CF206F4 for ; Sun, 17 Nov 2019 00:57:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727691AbfKQA5F (ORCPT ); Sat, 16 Nov 2019 19:57:05 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:57446 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727685AbfKQA5F (ORCPT ); Sat, 16 Nov 2019 19:57:05 -0500 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1iW8rv-0003Qn-TL; Sun, 17 Nov 2019 08:56:47 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1iW8rp-00046T-AW; Sun, 17 Nov 2019 08:56:41 +0800 Date: Sun, 17 Nov 2019 08:56:41 +0800 From: Herbert Xu To: "Maciej S. Szmigiero" Cc: Stephen Boyd , Theodore Ts'o , Arnd Bergmann , Greg Kroah-Hartman , Sebastian Andrzej Siewior , Keerthy , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] random: Don't freeze in add_hwgenerator_randomness() if stopping kthread Message-ID: <20191117005641.qgremf2lrj46qy4p@gondor.apana.org.au> References: <20191110135543.3476097-1-mail@maciej.szmigiero.name> <5dcee409.1c69fb81.f5027.48ad@mx.google.com> <415922ac-3c87-081c-6fdf-73fc97d0f397@maciej.szmigiero.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <415922ac-3c87-081c-6fdf-73fc97d0f397@maciej.szmigiero.name> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sun, Nov 17, 2019 at 12:01:20AM +0100, Maciej S. Szmigiero wrote: > > If a reader (user space) task is frozen then it is no longer waiting > on this waitqueue - at least if I understand correctly how the freezer > works for user space tasks, that is by interrupting waits via a fake > signal. At this point I'm just going to revert the whole thing and we can sort it out in the next development cycle. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt